Remove cass-operator namespace [K8SSAND-1239] #387
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Miles-Garnsey
changed the title
…lands in the right namespace. Add documentation comments to user-defined-ns test to explain what each step is doing w.r.t. namespacing.
Miles-Garnsey
force-pushed
the
remove-cass-ns
branch
from
2d73a75 to
a147a90
Compare
burmanm
approved these changes
Feb 15, 2022
|
@Miles-Garnsey we talked about this in standup this morning, we'll want to go ahead and get your change merged -- @burmanm has already approved, but there's test failures so I wasn't sure if those were related in any way possible? Or if some tests needed to be updated based on this change? |
|
@jdonenine I struggle to see how the e2e test failures could be related given that this PR just removes a namespace that was unused (and was passing before I made some non-related changes!) I think it may just be test flakiness due to the age of the base |
|
All tests passing and I have an approval. Squashed, merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
All components now install into the namespace k8ssandra-operator. But the cass-operator namespace is still created.
This PR adds a patch to delete it.
Which issue(s) this PR fixes:
Fixes #385
Checklist