Update to ginkgo v2 #422
Merged
Update to ginkgo v2 #422
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@emerkle826 No need to do this part, but you'll want this before starting to modify, otherwise conflicts are going to be quite horrible.. |
|
Yeah, I'll just need to find out what imports the v1 also to go.mod, that makes the tests fail.. |
|
Yep, the smoke test failure is not the test (the test passed), but something on GHA infra failing to close the test. |
emerkle826
approved these changes
Oct 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Updates dependency to ginkgo v2, fix controller tests and compilations. Does not use any of the new features in v2.
Which issue(s) this PR fixes:
Fixes #291
Checklist