Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

K8SSAND-1413 ⁃ Update to ginkgo v2 #291

Closed
burmanm opened this issue Mar 7, 2022 · 2 comments · Fixed by #422
Closed

K8SSAND-1413 ⁃ Update to ginkgo v2 #291

burmanm opened this issue Mar 7, 2022 · 2 comments · Fixed by #422
Labels
enhancement New feature or request

Comments

@burmanm
Copy link
Contributor

burmanm commented Mar 7, 2022 •
edited by sync-by-unito bot
Loading

What is missing?
ginkgo v1 is deprecated. We should update tests to ginkgo v2.

┆Issue is synchronized with this Jira Task by Unito
┆friendlyId: K8SSAND-1413
┆priority: Medium
@burmanm burmanm added the enhancement New feature or request label Mar 7, 2022
@sync-by-unito sync-by-unito bot changed the title Update to ginkgo v2 K8SSAND-1413 ⁃ Update to ginkgo v2 Apr 4, 2022
@jsanda
Copy link
Contributor

jsanda commented Apr 6, 2022

What about migrating tests to use Go's native testing?

@burmanm
Copy link
Contributor Author

burmanm commented Apr 7, 2022

Removing ginkgo + gomega for require/assert + testing.T is quite a lot of work. There's large amount of ginkgo tests already in the project and updating just to v2 should not be a large task.

Even if moving away from ginkgo later, I think it would make sense to ensure we have ginkgo v2 tests before that (and maybe some cleanup of tests).

@burmanm burmanm mentioned this issue Jul 26, 2022
Closed
@burmanm burmanm mentioned this issue Oct 3, 2022
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update to ginkgo v2 burmanm/cass-operator
3 participants
@jsanda @burmanm @adejanovski