-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
kernel: Set arguments based on CPU architecture #796
Conversation
Thanks for your PR,
To skip the vendors CIs, Maintainers can use one of:
|
8287e4c
to
5a7e2c2
Compare
Pull Request Test Coverage Report for Build 11591346372Details
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm !
@zeeke any idea why k8 CI is failing ? i see it creates a test pod and its stuck in pending state but i dont see it in downloaded artifacts |
Yep I was trying to look into the same issue and can't find the artifacts |
Hi @adrianchiris I check this one manually and this is the problem
not related to the PR for sure.. |
Kernel arguments like `intel_iommu=on` does not have sense on AMD or ARM systems and some user might complain about their presence, though they are likely to be harmless. Also, on ARM systems the `iommu.passthrough` parameter is the one to use [1]. Improve `GHWLib` to bridge CPU information from the library. Add `CpuInfoProviderInterface` and inject it into the GenericPlugin to implement the per CPU vendor logic. [1] https://github.com/torvalds/linux/blob/master/Documentation/admin-guide/kernel-parameters.txt#L2343 Signed-off-by: Andrea Panattoni <[email protected]>
To include - jaypipes/ghw#387 Signed-off-by: Andrea Panattoni <[email protected]>
5a7e2c2
to
5522c96
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
nice work!
Kernel arguments like
intel_iommu=on
does not have senseon AMD or ARM systems and some user might complain about
their presence, though they are likely to be harmless.
Also, on ARM systems the
iommu.passthrough
parameter is theone to use [1].
Improve
GHWLib
to bridge CPU information from the library.Add
CpuInfoProviderInterface
and inject it into the GenericPluginto implement the per CPU vendor logic.
Update github.com/jaypipes/ghw to include
Vendor
field for ARM cpus jaypipes/ghw#387[1] https://github.com/torvalds/linux/blob/master/Documentation/admin-guide/kernel-parameters.txt#L2343