Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Populate Vendor field for ARM cpus #387

Merged
merged 1 commit into from
Oct 24, 2024
Merged

Conversation

zeeke
Copy link
Contributor

@zeeke zeeke commented Oct 24, 2024

In ARM systems, the /proc/cpuinfo file does not contain vendor_id fields. In the lscpu tool, the CPU implementor code and a lookup table are used to provide a human-readable vendor name [1].

When running on ARM systems, populate the CPU.Info.Processors[*].Vendor field with the "ARM" string.

[1] util-linux/util-linux#564

In ARM  systems, `/proc/cpuinfo` file does not contain `vendor_id` fields. In `lscpu` tool,
the `CPU implementor` code and a lookup table is used to provide a human readable
vendor name [1].

Populate `cpu.Info.Processors[*].Vendor` field with "ARM" string when running in ARM systems.

[1] util-linux/util-linux#564

Signed-off-by: Andrea Panattoni <[email protected]>
Copy link
Owner

@jaypipes jaypipes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rock on! Thanks very much for the patch, @zeeke ! :)

@jaypipes jaypipes merged commit c1bfc6e into jaypipes:main Oct 24, 2024
12 checks passed
zeeke added a commit to zeeke/sriov-network-operator-1 that referenced this pull request Oct 25, 2024
To include
- jaypipes/ghw#387

Signed-off-by: Andrea Panattoni <[email protected]>
zeeke added a commit to zeeke/sriov-network-operator-1 that referenced this pull request Oct 25, 2024
To include
- jaypipes/ghw#387

Signed-off-by: Andrea Panattoni <[email protected]>
zeeke added a commit to zeeke/sriov-network-operator-1 that referenced this pull request Oct 25, 2024
To include
- jaypipes/ghw#387

Signed-off-by: Andrea Panattoni <[email protected]>
zeeke added a commit to zeeke/sriov-network-operator-1 that referenced this pull request Oct 25, 2024
To include
- jaypipes/ghw#387

Signed-off-by: Andrea Panattoni <[email protected]>
zeeke added a commit to zeeke/sriov-network-operator-1 that referenced this pull request Oct 25, 2024
To include
- jaypipes/ghw#387

Signed-off-by: Andrea Panattoni <[email protected]>
zeeke added a commit to zeeke/sriov-network-operator-1 that referenced this pull request Oct 25, 2024
To include
- jaypipes/ghw#387

Signed-off-by: Andrea Panattoni <[email protected]>
zeeke added a commit to zeeke/sriov-network-operator-1 that referenced this pull request Oct 30, 2024
To include
- jaypipes/ghw#387

Signed-off-by: Andrea Panattoni <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants