-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
multus: Use thin version #281
Conversation
Calico support officialy only multus thin, thick fails to create pods. We don't need here thick so lets use thin meanwhile. Signed-off-by: Or Shoval <[email protected]>
/cc @phoracek Talked with Calico people, they only test with multus thin |
passed |
Thanks for getting this addressed /approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: oshoval, phoracek The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
FIY @maiqueb there seem to be compatibility issues between Calico and thick Multus |
OK found out the reason. This issue reports this same issue. It's not only calico. Basically multus now doesn't has the path to any CNI plugins. I don't know how this could ever have passed CI ... Oh wait... I do know: in CI it uses a different manifest 0_o This PR broke it. This PR fixes it. @oshoval where are we using this Can you take care of that ? |
Nice, about the question - mentioned on PR desc (manifest is used at |
What this PR does / why we need it:
Calico officially supports only multus thin,
thick fails to create pods [1]
We don't need here thick so lets use thin meanwhile (as cnao does).
[1] https://prow.ci.kubevirt.io/view/gs/kubevirt-prow/pr-logs/pull/k8snetworkplumbingwg_ovs-cni/279/pull-e2e-ovs-cni/1706970379018309632
Special notes for your reviewer:
It seems we are using https://raw.githubusercontent.com/k8snetworkplumbingwg/multus-cni/v4.0.1/deployments/multus-daemonset-thick.yml
which has
image: ghcr.io/k8snetworkplumbingwg/multus-cni:snapshot-thick
same tag is used also on 4.0.2 and such, hence it might started to break suddenly when multus was changed.
Thin also have this problem (common tag between versions), so we should freeze by hash or so in a follow PR,
as CNAO does.
Release note: