Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kubevirtci: Downgrade to 1.25 #280

Closed
wants to merge 1 commit into from

Conversation

oshoval
Copy link
Member

@oshoval oshoval commented Sep 27, 2023

What this PR does / why we need it:
Align with CNAO.
Check if here the tests are passing.

Special notes for your reviewer:
Failures for example
https://prow.ci.kubevirt.io/view/gs/kubevirt-prow/pr-logs/pull/k8snetworkplumbingwg_ovs-cni/279/pull-e2e-ovs-cni/1706970379018309632
pod can't be created failed to find plugin "calico" in path [/opt/cni/bin]
It seems we need to update calico according projectcalico/calico#6218
but not sure this is the problem

Release note:

None

@kubevirt-bot kubevirt-bot added dco-signoff: yes Indicates the PR's author has DCO signed all their commits. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Sep 27, 2023
@kubevirt-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: oshoval
Once this PR has been reviewed and has the lgtm label, please assign phoracek for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Sep 27, 2023
@kubevirt-bot
Copy link
Collaborator

@oshoval: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-e2e-ovs-cni 8170957 link true /test pull-e2e-ovs-cni

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@oshoval
Copy link
Member Author

oshoval commented Sep 27, 2023

doesnt help

maybe worth to align more stuff which are different versus how cnao runs ovs cni, such as multus

@oshoval oshoval closed this Sep 27, 2023
@oshoval
Copy link
Member Author

oshoval commented Sep 28, 2023

Note that if i tried to delete calico pods, sometimes one of them didnt manage to restart due to the same error as above
and i saw this

$ oc logs -n kube-system kube-apiserver-node01  | grep validated
E0927 14:28:25.716451       1 authentication.go:63] "Unable to authenticate the request" err="[invalid bearer token, service account token has been invalidated]"

which is also mentioned here projectcalico/calico#5684 (comment)

i think the right way is to try to align everything with CNAO, to see what is the moving part that does it
(updating calico didnt help)
worth to check if it is because we are using here multus thick
(need to check if cnao uses thin, calico test only with thin)

see #281

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dco-signoff: yes Indicates the PR's author has DCO signed all their commits. release-note-none Denotes a PR that doesn't merit a release note.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants