-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added advertise address integration test #8344
Added advertise address integration test #8344
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is no need to make a individual test for a single flag, this is why we have the startup test https://github.com/k3s-io/k3s/blob/master/tests/integration/startup/startup_int_test.go#L84. You should expand the existing testlet which is already creating and cleaning up dummy interfaces.
Signed-off-by: Vitor Savian <[email protected]>
2aee59d
to
bdfc4d3
Compare
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #8344 +/- ##
==========================================
+ Coverage 44.66% 51.46% +6.79%
==========================================
Files 143 143
Lines 14746 15229 +483
==========================================
+ Hits 6587 7837 +1250
+ Misses 7119 6171 -948
- Partials 1040 1221 +181
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
Proposed Changes
Integration test for
---advertise-address
flagTypes of Changes
Integration test
Verification
sudo go test ./tests/integration/advertise/... -run Integration
Testing
Linked Issues
User-Facing Change
Further Comments