Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Epic] Add Integration Test for all server/agent flags #6057

Closed
Tracked by #6070
rancher-max opened this issue Aug 30, 2022 · 7 comments
Closed
Tracked by #6070

[Epic] Add Integration Test for all server/agent flags #6057

rancher-max opened this issue Aug 30, 2022 · 7 comments
Assignees
Labels
kind/task Work not related to bug fixes or new functionality kind/test
Milestone

Comments

@rancher-max
Copy link
Contributor

rancher-max commented Aug 30, 2022

Similar to #6056, but this is for a single test that uses ALL (or the most possible) configuration flags.

EDIT 04/11/23
Integration Server Flags Testing Status

Server flags:
  • disable
  • disable-network-policy
  • with-node-id
  • write-kubeconfig-mode
  • flannel-external-ip
  • selinux
  • cluster-init
  • disable-scheduler
  • node-taint
  • data-dir
  • token
  • server
  • node-label
  • cluster-cidr
  • node-name
  • flannel-ipv6-masq
  • node-ip
  • kubelet-arg
  • bind-address
  • snapshotter
  • secrets-encryption
  • node-external-ip
  • disable-helm-controller
  • flannel-iface
  • service-cidr
  • multi-cluster-cidr
  • tls-san
  • flannel-backend
  • etcd-arg
  • prefer-bundled-bin
  • debug
  • kube-proxy-arg
  • kube-controller-manager-arg
  • write-kubeconfig
  • etcd-snapshot-retention
  • log
  • agent-token-file
  • kube-apiserver-arg
  • disable-cloud-controller
  • resolv-conf
  • etcd-expose-metrics
  • lb-server-port
  • https-listen-port
  • advertise-port
  • cluster-dns
  • etcd-snapshot-name
  • default-local-storage-path
  • vmodule
  • kube-scheduler-arg
  • kube-cloud-controller-manager-arg
  • token-file
  • etcd-disable-snapshots
  • etcd-snapshot-schedule-cron
  • etcd-snapshot-dir
  • disable-kube-proxy
  • advertise-address
  • agent-token
  • datastore-cafile
  • etcd-snapshot-compress
  • alsologtostderr
  • servicelb-namespace
  • egress-selector-mode
  • config
  • protect-kernel-defaults
  • enable-pprof
  • service-node-port-range
  • cluster-reset-restore-path

The following flags are unsuited for Integration test

Not For Integration Test
❌ system-default-registry ❌ cluster-domain ❌ etcd-s3-folder
❌ private-registry ❌ etcd-s3-region ❌ etcd-s3
❌ datastore-endpoint ❌ image-credential-provider-bin-dir ❌ docker
❌ datastore-certfile ❌ etcd-s3-secret-key ❌ pause-image
❌ etcd-s3-access-key ❌ flannel-cni-conf ❌ rootless
❌ datastore-keyfile ❌ etcd-s3-insecure ❌ etcd-s3-skip-ssl-verify
❌ container-runtime-endpoint ❌ image-credential-provider-config ❌ etcd-s3-endpoint
❌ etcd-s3-endpoint-ca ❌ etcd-s3-bucket ❌ etcd-s3-timeout
❌ flannel-conf ❌ cluster-reset
@rancher-max rancher-max added kind/task Work not related to bug fixes or new functionality kind/test labels Aug 30, 2022
@cwayne18 cwayne18 added this to the v1.24.5+k3s1 milestone Aug 30, 2022
@caroline-suse-rancher
Copy link
Contributor

@rancher-max is this still in progress?

@rancher-max
Copy link
Contributor Author

Yes I don't think any of us have picked it up to start working yet.

@caroline-suse-rancher
Copy link
Contributor

I'll move milestones then, thank you!

@caroline-suse-rancher
Copy link
Contributor

@osodracnai Hey! Are you still working on this? The last linked PR I see is from May. Thanks!

@caroline-suse-rancher caroline-suse-rancher removed this from the v1.24.15+k3s1 milestone Jul 10, 2023
@caroline-suse-rancher caroline-suse-rancher added this to the v1.25.13+k3s1 milestone Jul 10, 2023
@osodracnai
Copy link
Contributor

@caroline-suse-rancher Yeah, but not only focused on it. If you want i can make it my priority.

@caroline-suse-rancher
Copy link
Contributor

@osodracnai No, no worries! Just asking for a status update, that sounds good :)

@dereknola
Copy link
Member

Closing this as complete, all easily testable flags via integration test have been covered.

@github-project-automation github-project-automation bot moved this from Working to Done Issue in K3s Development Mar 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/task Work not related to bug fixes or new functionality kind/test
Projects
Archived in project
Development

No branches or pull requests

5 participants