Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add kube-* server flags integration tests #7416

Merged
merged 1 commit into from
May 8, 2023
Merged

add kube-* server flags integration tests #7416

merged 1 commit into from
May 8, 2023

Conversation

osodracnai
Copy link
Contributor

@osodracnai osodracnai commented May 3, 2023 •
edited
Loading

Proposed Changes

Adds an integration test to check if args passed by the flags are been consumed and used

"--kube-apiserver-arg"
"--kube-controller-manager-arg"
"--kube-scheduler-arg"
"--kube-cloud-controller-manager-arg"
"--kubelet-arg"
"--kube-proxy-arg"

Types of Changes

Verification

Testing

Linked Issues

#6057

User-Facing Change

Further Comments

@osodracnai osodracnai requested a review from a team as a code owner May 3, 2023 15:58
@osodracnai osodracnai force-pushed the add-kube-flag-tests branch 2 times, most recently from a7a5d4b to 627beb9 Compare May 3, 2023 17:32
brandond
brandond approved these changes May 3, 2023
View reviewed changes
Copy link
Member

@brandond brandond left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Doesn't need to block this, but I'd love to see this also cover kubelet and etcd args, just for consistency's sake.

@osodracnai
Copy link
Contributor Author

There is already tests for etcd-args on tests/integration/custometcdargs/custometcdargs_int_test.go, but i'll write for kubelet

@osodracnai osodracnai force-pushed the add-kube-flag-tests branch from 627beb9 to 6a4ce71 Compare May 4, 2023 15:45
@osodracnai
add kube-* server flags integration tests
0f7e687 
This commit adds SearchK3sLog to find specific strings in integration tests log file and also removes FindStringInCmdAsync function since it was not being used.

Signed-off-by: Ian Cardoso <[email protected]>
@osodracnai osodracnai force-pushed the add-kube-flag-tests branch from 6a4ce71 to 0f7e687 Compare May 5, 2023 11:46
@codecov
Copy link

codecov bot commented May 5, 2023 •
edited
Loading

Codecov Report

Patch coverage has no change and project coverage change: +0.09 🎉

Comparison is base (a3ddff2) 19.35% compared to head (0f7e687) 19.45%.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #7416      +/-   ##
==========================================
+ Coverage   19.35%   19.45%   +0.09%     
==========================================
  Files          81       81              
  Lines        5445     5495      +50     
==========================================
+ Hits         1054     1069      +15     
- Misses       4169     4204      +35     
  Partials      222      222
Flag Coverage Δ
unittests 19.45% <ø> (+0.09%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 5 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@osodracnai osodracnai merged commit 3982213 into k3s-io:master May 8, 2023
osodracnai added a commit to osodracnai/k3s that referenced this pull request May 8, 2023
@osodracnai
add kube-* server flags integration tests (k3s-io#7416)
8964b3a 
This commit adds SearchK3sLog function to find specific strings in integration tests log file and also removes FindStringInCmdAsync function since it was not being used.

Signed-off-by: Ian Cardoso <[email protected]>
(cherry picked from commit 3982213)
osodracnai added a commit to osodracnai/k3s that referenced this pull request May 8, 2023
@osodracnai
add kube-* server flags integration tests (k3s-io#7416)
210719d 
This commit adds SearchK3sLog function to find specific strings in integration tests log file and also removes FindStringInCmdAsync function since it was not being used.

Signed-off-by: Ian Cardoso <[email protected]>
(cherry picked from commit 3982213)
@osodracnai osodracnai mentioned this pull request May 8, 2023
Closed
osodracnai added a commit to osodracnai/k3s that referenced this pull request May 8, 2023
@osodracnai
add kube-* server flags integration tests (k3s-io#7416)
4ca7cf1 
This commit adds SearchK3sLog function to find specific strings in integration tests log file and also removes FindStringInCmdAsync function since it was not being used.

Signed-off-by: Ian Cardoso <[email protected]>
(cherry picked from commit 3982213)
Signed-off-by: Ian Cardoso <[email protected]>
osodracnai added a commit to osodracnai/k3s that referenced this pull request May 8, 2023
@osodracnai
add kube-* server flags integration tests (k3s-io#7416)
bda0720 
This commit adds SearchK3sLog function to find specific strings in integration tests log file and also removes FindStringInCmdAsync function since it was not being used.

Signed-off-by: Ian Cardoso <[email protected]>
osodracnai added a commit to osodracnai/k3s that referenced this pull request May 9, 2023
@osodracnai
add kube-* server flags integration tests (k3s-io#7416)
7033b74 
This commit adds SearchK3sLog function to find specific strings in integration tests log file and also removes FindStringInCmdAsync function since it was not being used.

Signed-off-by: Ian Cardoso <[email protected]>
@osodracnai osodracnai mentioned this pull request May 9, 2023
Merged
osodracnai added a commit to osodracnai/k3s that referenced this pull request May 9, 2023
@osodracnai
add kube-* server flags integration tests (k3s-io#7416)
2673edd 
This commit adds SearchK3sLog function to find specific strings in integration tests log file and also removes FindStringInCmdAsync function since it was not being used.

Signed-off-by: Ian Cardoso <[email protected]>
(cherry picked from commit 3982213)
@osodracnai osodracnai mentioned this pull request May 9, 2023
Merged
osodracnai added a commit to osodracnai/k3s that referenced this pull request May 9, 2023
@osodracnai
add kube-* server flags integration tests (k3s-io#7416)
38d22ab 
This commit adds SearchK3sLog function to find specific strings in integration tests log file and also removes FindStringInCmdAsync function since it was not being used.

Signed-off-by: Ian Cardoso <[email protected]>
(cherry picked from commit 3982213)
Signed-off-by: Ian Cardoso <[email protected]>
osodracnai added a commit to osodracnai/k3s that referenced this pull request May 9, 2023
@osodracnai
add kube-* server flags integration tests (k3s-io#7416)
a5f6be0 
This commit adds SearchK3sLog function to find specific strings in integration tests log file and also removes FindStringInCmdAsync function since it was not being used.

Signed-off-by: Ian Cardoso <[email protected]>
(cherry picked from commit 3982213)
@osodracnai osodracnai mentioned this pull request May 9, 2023
Merged
osodracnai added a commit to osodracnai/k3s that referenced this pull request May 9, 2023
@osodracnai
add kube-* server flags integration tests (k3s-io#7416)
756ee72 
This commit adds SearchK3sLog function to find specific strings in integration tests log file and also removes FindStringInCmdAsync function since it was not being used.

Signed-off-by: Ian Cardoso <[email protected]>
(cherry picked from commit 3982213)
Signed-off-by: Ian Cardoso <[email protected]>
osodracnai added a commit that referenced this pull request May 9, 2023
@osodracnai
add kube-* server flags integration tests (#7416)
2cb4eef 
This commit adds SearchK3sLog function to find specific strings in integration tests log file and also removes FindStringInCmdAsync function since it was not being used.

Signed-off-by: Ian Cardoso <[email protected]>
(cherry picked from commit 3982213)
Signed-off-by: Ian Cardoso <[email protected]>
osodracnai added a commit that referenced this pull request May 9, 2023
@osodracnai
add kube-* server flags integration tests (#7416)
b28d4ae 
This commit adds SearchK3sLog function to find specific strings in integration tests log file and also removes FindStringInCmdAsync function since it was not being used.

Signed-off-by: Ian Cardoso <[email protected]>
(cherry picked from commit 3982213)
Signed-off-by: Ian Cardoso <[email protected]>
osodracnai added a commit that referenced this pull request May 9, 2023
@osodracnai
add kube-* server flags integration tests (#7416)
414cc27 
This commit adds SearchK3sLog function to find specific strings in integration tests log file and also removes FindStringInCmdAsync function since it was not being used.

Signed-off-by: Ian Cardoso <[email protected]>
@cguertin14 cguertin14 mentioned this pull request May 31, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dereknola dereknola dereknola approved these changes

@brandond brandond brandond approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@osodracnai @brandond @dereknola