Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-1.25] Bugfix: do not break cert-manager when pprof is enabled #6837

Merged

Conversation

brandond
Copy link
Member

Proposed Changes

Change router set up when --enable-pprof is enabled so that cert-manager will install correctly.

Types of Changes

Bugfix.

Verification

Testing

Only tested manually, only really relevant for developers. Please advise if any kind of automated test is required to get the PR merged.

Linked Issues

User-Facing Change

NONE

Signed-off-by: Silvio Moioli <[email protected]>
(cherry picked from commit 23c1040)
Signed-off-by: Brad Davidson <[email protected]>
@brandond brandond requested a review from a team as a code owner January 26, 2023 23:21
@codecov-commenter
Copy link

Codecov Report

Base: 9.62% // Head: 9.62% // No change to project coverage 👍

Coverage data is based on head (ff5344e) compared to base (4c17994).
Patch coverage: 0.00% of modified lines in pull request are covered.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@             Coverage Diff              @@
##           release-1.25   #6837   +/-   ##
============================================
  Coverage          9.62%   9.62%           
============================================
  Files               140     140           
  Lines             10284   10284           
============================================
  Hits                990     990           
  Misses             9090    9090           
  Partials            204     204           
Flag Coverage Δ
unittests 9.62% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/cluster/https.go 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@brandond brandond merged commit d6fa972 into k3s-io:release-1.25 Jan 27, 2023
@brandond brandond deleted the fix_cert_manager_pprof_release-1.25 branch June 6, 2024 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants