Bugfix: do not break cert-manager when pprof is enabled #6635
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Silvio Moioli <[email protected]>
brandond
approved these changes
Dec 12, 2022
|
Thanks for the PR! We're currently in code freeze for upstream releases, but we'll merge this once that's over. |
|
Perfect, this is by no means urgent, waiting some time is not a problem. And, thanks for the super fast review! |
dereknola
approved these changes
Dec 16, 2022
brandond
pushed a commit
to brandond/k3s
that referenced
this pull request
Jan 26, 2023
Signed-off-by: Silvio Moioli <[email protected]> (cherry picked from commit 23c1040) Signed-off-by: Brad Davidson <[email protected]>
brandond
pushed a commit
to brandond/k3s
that referenced
this pull request
Jan 26, 2023
Signed-off-by: Silvio Moioli <[email protected]> (cherry picked from commit 23c1040) Signed-off-by: Brad Davidson <[email protected]>
brandond
pushed a commit
to brandond/k3s
that referenced
this pull request
Jan 26, 2023
Signed-off-by: Silvio Moioli <[email protected]> (cherry picked from commit 23c1040) Signed-off-by: Brad Davidson <[email protected]>
brandond
pushed a commit
that referenced
this pull request
Jan 27, 2023
Signed-off-by: Silvio Moioli <[email protected]> (cherry picked from commit 23c1040) Signed-off-by: Brad Davidson <[email protected]>
brandond
pushed a commit
that referenced
this pull request
Jan 27, 2023
Signed-off-by: Silvio Moioli <[email protected]> (cherry picked from commit 23c1040) Signed-off-by: Brad Davidson <[email protected]>
brandond
pushed a commit
that referenced
this pull request
Jan 27, 2023
Signed-off-by: Silvio Moioli <[email protected]> (cherry picked from commit 23c1040) Signed-off-by: Brad Davidson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Change router set up when
--enable-pprofis enabled so that cert-manager will install correctly.Types of Changes
Bugfix.
Verification
--enable-pprofoptionTesting
Only tested manually, only really relevant for developers. Please advise if any kind of automated test is required to get the PR merged.
Linked Issues
Fixes #6634
User-Facing Change