Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[engine-1.21] Reduce node startup time #4362

Merged
merged 3 commits into from
Oct 29, 2021

Conversation

brandond
Copy link
Member

Proposed Changes

  • If using the built-in CCM, wait for it to clear the uninitialized taint before starting the scheduler to ensure that pods can be scheduled immediately.
  • Optimize agent startup time by watching the local node instead of getting/sleeping in a loop.

Types of Changes

bugfix

Verification

See linked issue

Linked Issues

User-Facing Change

Resolved an issue that would occasionally cause K3s to take more than a minute to schedule initial pods on the first server in a cluster.

Further Comments

Signed-off-by: Brad Davidson <[email protected]>
(cherry picked from commit 3fe460d)
Signed-off-by: Brad Davidson <[email protected]>
(cherry picked from commit 5acd0b9)
… err

Signed-off-by: Brad Davidson <[email protected]>
(cherry picked from commit 3da1bb3)
@brandond brandond requested a review from a team as a code owner October 29, 2021 22:47
@codecov-commenter
Copy link

codecov-commenter commented Oct 29, 2021

Codecov Report

Merging #4362 (2ad5925) into engine-1.21 (998e2bb) will decrease coverage by 0.03%.
The diff coverage is 1.66%.

Impacted file tree graph

@@               Coverage Diff               @@
##           engine-1.21    #4362      +/-   ##
===============================================
- Coverage        11.47%   11.43%   -0.04%     
===============================================
  Files              139      139              
  Lines             9036     9067      +31     
===============================================
  Hits              1037     1037              
- Misses            7774     7805      +31     
  Partials           225      225              
Flag Coverage Δ
inttests 0.67% <1.66%> (-0.01%) ⬇️
unittests 11.09% <1.66%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/agent/flannel/setup.go 0.00% <0.00%> (ø)
pkg/agent/run.go 0.00% <0.00%> (ø)
pkg/agent/tunnel/tunnel.go 0.00% <0.00%> (ø)
pkg/server/context.go 0.00% <0.00%> (ø)
pkg/daemons/executor/embed.go 1.13% <3.22%> (-0.56%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 998e2bb...2ad5925. Read the comment docs.

@brandond brandond merged commit 4a9a216 into k3s-io:engine-1.21 Oct 29, 2021
@brandond brandond deleted the fix_4340_engine-1.21 branch June 6, 2024 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants