Fix other uses of NewForConfigOrDie in contexts where we could return…

… err Signed-off-by: Brad Davidson <[email protected]>
brandond · Oct 29, 2021 · 3da1bb3 · 3da1bb3
1 parent 5acd0b9
commit 3da1bb3
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 2 deletions.
diff --git a/pkg/daemons/control/server.go b/pkg/daemons/control/server.go
@@ -347,7 +347,10 @@ func checkForCloudControllerPrivileges(ctx context.Context, runtime *config.Cont
 	if err != nil {
 		return err
 	}
-	authClient := authorizationv1client.NewForConfigOrDie(restConfig)
+	authClient, err := authorizationv1client.NewForConfig(restConfig)
+	if err != nil {
+		return err
+	}
 	sar := &authorizationv1.SubjectAccessReview{
 		Spec: authorizationv1.SubjectAccessReviewSpec{
 			User: version.Program + "-cloud-controller-manager",

diff --git a/pkg/server/context.go b/pkg/server/context.go
@@ -60,7 +60,10 @@ func NewContext(ctx context.Context, cfg string) (*Context, error) {
 		return nil, errors.Wrap(err, "failed to register CRDs")
 	}
 
-	k8s := kubernetes.NewForConfigOrDie(restConfig)
+	k8s, err := kubernetes.NewForConfig(restConfig)
+	if err != nil {
+		return nil, err
+	}
 	return &Context{
 		K3s:   k3s.NewFactoryFromConfigOrDie(restConfig),
 		Helm:  helm.NewFactoryFromConfigOrDie(restConfig),