Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't cordon all workers at once when upgrading #672

Merged
merged 1 commit into from
Mar 28, 2024
Merged

Don't cordon all workers at once when upgrading #672

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions phase/upgrade_workers.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,20 +76,21 @@ func (p *UpgradeWorkers) CleanUp() {

// Run the phase
func (p *UpgradeWorkers) Run() error {
if err := p.hosts.Each(p.cordonWorker); err != nil {
return err
}

// Upgrade worker hosts parallelly in 10% chunks
concurrentUpgrades := int(math.Floor(float64(len(p.hosts)) * 0.10))
if concurrentUpgrades == 0 {
concurrentUpgrades = 1
}

log.Infof("Upgrading max %d workers in parallel", concurrentUpgrades)
return p.hosts.BatchedParallelEach(concurrentUpgrades,
err := p.hosts.BatchedParallelEach(concurrentUpgrades,
p.start,
p.cordonWorker,
)
if err != nil {
return err
}
return p.hosts.BatchedParallelEach(concurrentUpgrades,
p.drainWorker,
p.upgradeWorker,
p.uncordonWorker,
Expand Down
Loading