Don't cordon all workers at once when upgrading #672
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jnummelin
previously approved these changes
Mar 28, 2024
Signed-off-by: Kimmo Lehto <[email protected]>
jnummelin
approved these changes
Mar 28, 2024
|
I used k0sctl v0.17.8 and I confirmed that all workers cordoned before upgrading. Why does you create another BatchedParallelEach? @kke |
Yes I don't see any reason why it couldn't be in the existing one looking at it now with fresh eyes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #670
There was a mistake in #595 that made worker upgrading cordon all the workers before an upgrade. The intention was to cordon only the current batch, so that workloads don't migrate to the nodes in the same batch.