WIP/poc, use k0s config api from k0s pkg #287
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The built binary is apparently not noticeably grown by the inclusion of k0s. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will pretty much require converting k0sctl to use the funny yaml package used in k0s and apparently the rest of the k8s ecosystem.
Benefits: local validation and default config, no config digging, access to k0s's config manipulation functions (for dynamic config etc)
Downsides: this kind of locks k0sctl to certain versions of k0s, the k0s api-version, like the k0sctl's too, has never been bumped from v1beta1 albeit plethora of changes.