Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

”k0sctl init --k0s” Container image version is not up to date. #322

Closed
chattytak opened this issue Feb 13, 2022 · 3 comments · Fixed by #329
Closed

”k0sctl init --k0s” Container image version is not up to date. #322

chattytak opened this issue Feb 13, 2022 · 3 comments · Fixed by #329
Labels
chore Housekeeping / typo / code quality improvements enhancement New feature or request

Comments

@chattytak
Copy link

The version of the main unit is set to the latest, but the version in images is still old.

# k0sctl version
version: v0.12.6
commit: d5f7d66
# k0sctl init --k0s
<snip>
  k0s:
    version: 1.23.3+k0s.0
    config:
<snip>
      spec:
<snip>
        images:
          calico:
            cni:
              image: docker.io/calico/cni
              version: v3.18.1
            kubecontrollers:
              image: docker.io/calico/kube-controllers
              version: v3.18.1
            node:
              image: docker.io/calico/node
              version: v3.18.1
          coredns:
            image: docker.io/coredns/coredns
            version: 1.7.0
          default_pull_policy: IfNotPresent
          konnectivity:
            image: us.gcr.io/k8s-artifacts-prod/kas-network-proxy/proxy-agent
            version: v0.0.24
          kubeproxy:
            image: k8s.gcr.io/kube-proxy
            version: v1.22.1
          kuberouter:
            cni:
              image: docker.io/cloudnativelabs/kube-router
              version: v1.2.1
            cniInstaller:
              image: quay.io/k0sproject/cni-node
              version: 0.1.0
          metricsserver:
            image: gcr.io/k8s-staging-metrics-server/metrics-server
            version: v0.5.0
@kke kke added chore Housekeeping / typo / code quality improvements enhancement New feature or request labels Feb 14, 2022
@kke
Copy link
Contributor

kke commented Feb 14, 2022

Yes, this is problematic. I started something to use the config packages directly from k0s in #287 but it wasn't finished. It also would require constant updating like the current copy&paste k0s config template.

Maybe k0s releases could have the output of k0s default-config or k0s config create on github 🤔 Using k0sctl init --k0s would then look up the release on github and try to find the default config from there.

Another option would be to just remove the --k0s.

@r3h0
Copy link

r3h0 commented Feb 16, 2022

I'm looking for a workaround and want to check my understanding: both k0s default-config and k0s config create produce the authoritative default config; the output of either of those commands should be used to patch the spec.k0s section of the init file created with k0sctl init --k0s.

Did I get that right?

@kke
Copy link
Contributor

kke commented Feb 16, 2022

Yes. The problem is that k0sctl init can't go run the actual k0s to generate the config as at that point you're in the process of creating a config without having a k0s deployed somewhere yet, that's why it's currently just copy-pasted into code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Housekeeping / typo / code quality improvements enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants