Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't export prefixed methods in +server.ts #687

Merged
merged 3 commits into from
Jul 29, 2024
Merged

Conversation

Dan1ve
Copy link
Contributor

@Dan1ve Dan1ve commented Jul 28, 2024

Fix #685

Copy link

nx-cloud bot commented Jul 29, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit d6eca67. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 2 targets

Sent with 💌 from NxCloud.

@jycouet
Copy link
Owner

jycouet commented Jul 29, 2024

@all-contributors please add @Dan1ve for code

Copy link
Contributor

@jycouet

I've put up a pull request to add @Dan1ve! 🎉

@jycouet jycouet changed the title #685 Don't export prefixed methods Don't export prefixed methods in +server.ts Jul 29, 2024
@jycouet jycouet merged commit db682d4 into jycouet:main Jul 29, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Methods with _ prefix shouldn't be exported
2 participants