-
-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Methods with _
prefix shouldn't be exported
#685
Comments
Hummm, yes you are right, good catch 👍. You want to fix it ? Or could you do a repro that I will use to add tests 😉 Thank you |
Dan1ve
added a commit
to Dan1ve/kitql
that referenced
this issue
Jul 28, 2024
Please see this PR: #687 I checked the tests but it wasn't immediately clear to me how the comparison (expected vs actual) is done. |
jycouet
added a commit
that referenced
this issue
Jul 29, 2024
* #685 Don't export prefixed methods * ✅ NEW: tests for underscore * ✏️ UPDATE: changeset --------- Co-authored-by: jycouet <[email protected]>
A bit late, but thanks a lot for the amazing response time and fix! 🥇 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
If you have a
+server.ts
endpoint that contains a "private" method like this:Note the
_
prefix, which tells Sveltekit that this should act as a regular function, not an endpoint.However, there will be a corresponding entry in the generated
ROUTES
file, which is unexpected IMHO.Severity
annoyance
Steps to Reproduce the Bug
see above :)
Reproduction
No response
The text was updated successfully, but these errors were encountered: