Skip to content
This repository has been archived by the owner on Nov 29, 2022. It is now read-only.

[email protected] - Scss unit testing #376

Merged
merged 14 commits into from
Jul 5, 2022
Merged

Conversation

jamieomaguire
Copy link
Contributor

v9.0.0-beta.6

July 01, 2022

Added

  • SCSS unit testing capabilities using sass-true
  • New unit testing directory (to avoid packaging tests with npm)

Changed

  • yarn test command specifies which jest.config.js file to use

@jamieomaguire jamieomaguire changed the title Unit test sass 1 [email protected] - Scss unit testing Jul 1, 2022
@jamieomaguire jamieomaguire added Do not merge not ready to be reviewed dependencies Pull requests that update a dependency file labels Jul 1, 2022
Copy link
Contributor

@ashleynolan ashleynolan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Some really minor comments, otherwise LGTM.

CHANGELOG.md Outdated Show resolved Hide resolved
.eslintrc.js Outdated Show resolved Hide resolved
src/test/scss/scss.spec.js Outdated Show resolved Hide resolved
src/test/scss/scss.spec.js Outdated Show resolved Hide resolved
src/test/scss/tools/functions/px-to-em.spec.scss Outdated Show resolved Hide resolved
@jamieomaguire jamieomaguire merged commit 14da643 into v9.0.0-beta.0 Jul 5, 2022
@jamieomaguire jamieomaguire deleted the unit-test-sass-1 branch July 5, 2022 14:14
ashleynolan added a commit that referenced this pull request Aug 9, 2022
* v9.0.0-beta.0 (#369)

* Commenting out dependencies (migration)

* v9.0.0 - Migrate to use & forward initial work.

* v9.0.0 - Migrate to use & forward initial work.

* v9.0.0-beta.0 - Move to use & forward syntax.

* v9.0.0-beta.0 - add templates back in.

* v9.0.0-beta.0 - resolve paths.

* v9.0.0-beta.0 - fix paths.

* Updating README and CHANGELOG

* v9.0.0-beta.0 - Move trumps back.

* v9.0.0-beta.0 - Move trumps to correct position

* v9.0.0-beta.0 - PR comments.

* v9.0.0-beta.0 - PR comments.

* v9.0.0-beta.0 - PR comments.

* v9.0.0-beta.0 - PR comments.

Co-authored-by: ashleynolan <[email protected]>

* v9.0.0-beta.1 - Fixed mixin reference. (#370)

* v9.0.0-beta.1 - Fixed mixin reference.

* v9.0.0-beta.1 - update changelog.

* v9.0.0-beta.2 - update @use rules in _type.scss (#371)

* fix line-height function call

* bump beta version

* import as wildcard

* remove wildcard from use statements

* update changelog

* fix zindex

* V9.0.0 beta.4 - fix some missing modules (#373)

* update functions

* update mixin

* update changelog and bump package version

* V9-0.0 beta.5 - fix circular reference (#375)

* update functions

* update mixin

* update changelog and bump package version

* remove circular references from variables, funcs and mixins

* update version and changelog

* remove debug code

* tidy code

* [email protected] - Scss unit testing (#376)

* install sass-true

* install glob

* add working function unit tests

* test a mixin

* bump package and changelog

* rename some tests

* Update CHANGELOG.md

Co-authored-by: Ashley Watson-Nolan <[email protected]>

* Update src/test/scss/scss.spec.js

Co-authored-by: Ashley Watson-Nolan <[email protected]>

* Update src/test/scss/scss.spec.js

Co-authored-by: Ashley Watson-Nolan <[email protected]>

* update test paths

* remove eslint override

* update test names

* rename setup file

* Update src/test/scss/tools/mixins/type.spec.scss

Co-authored-by: Xander Marjoram <[email protected]>

Co-authored-by: Ashley Watson-Nolan <[email protected]>
Co-authored-by: Xander Marjoram <[email protected]>

* v9.0.0-beta.7 - scss unit tests on publish (#377)

* v8.3.0 - Add sass:map. (#372)

* v8.3.0 - Add sass:map.

* v8.3.0 - PR comment.

* test scss before publishing

* update test script to run concurrently

* add circleci config

* v8.4.0 - Circleci setup (#378)

* Add .circleci/config.yml

* Add .circleci/config.yml

* setup circle

* remove travis config

Co-authored-by: Kevin Rodrigues <[email protected]>

* v9.0.0-beta.8 - Remove tilde import. (#382)

* v9.0.0-beta.8 - Remove tilde import.

* v9.0.0-beta.8 - Remove tilde import.

* v9.0.0-beta.9 - Remove listingSkeleton mixin (#383)

* Remove listingSkeleton mixin and bump version

* Update readme

Co-authored-by: Kathy Lee <[email protected]>

* v9.0.0-beta.10 – $font-size-base fix and minor design token update (#384)

Co-authored-by: Ashley Watson-Nolan <[email protected]>

* v9.0.0-beta.11 – font-size mixin updated to new default and package updates (#385)

Co-authored-by: Ashley Watson-Nolan <[email protected]>

* v9.0.0-beta.12 - Add back listing skeleton. (#386)

* v9.0.0-beta.12 - Add back listing skeleton.

* v9.0.0-beta.12 - Fix spelling.

* v9.0.0 - PR comment.

* v9.0.0 - version release v9

* v9.0.0 - remove changelog entry.

* v9.0.0 - Add back previous beta log.

Co-authored-by: ashleynolan <[email protected]>
Co-authored-by: Jamie Maguire <[email protected]>
Co-authored-by: Ashley Watson-Nolan <[email protected]>
Co-authored-by: Xander Marjoram <[email protected]>
Co-authored-by: Kathy Lee <[email protected]>
Co-authored-by: Kathy Lee <[email protected]>
Co-authored-by: Ashley Watson-Nolan <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants