This repository has been archived by the owner on Nov 29, 2022. It is now read-only.
v9.0.0-beta.0 #369
Merged
v9.0.0-beta.0 #369
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| * Define associated Table variables | ||
| */ | ||
| $table-bgColor : dt.$color-container-default !global; // Default background color used for all tables. | ||
| $table-bgColor--accent : dt.$color-grey-10 !global; // Background color used for `.table-striped`. |
There was a problem hiding this comment.
Does the class .table-striped still exist?
There was a problem hiding this comment.
I'm not 100%. Would like to avoid changing or modifying code outside of what this PR should be doing if possible. I can create a ticket to see if anyone uses it or if we're certain now I can delete it altogether.
ashleynolan
reviewed
Jun 6, 2022
ashleynolan
approved these changes
Jun 7, 2022
DamianMullins
approved these changes
Jun 7, 2022
ashleynolan
added a commit
that referenced
this pull request
Aug 9, 2022
* v9.0.0-beta.0 (#369) * Commenting out dependencies (migration) * v9.0.0 - Migrate to use & forward initial work. * v9.0.0 - Migrate to use & forward initial work. * v9.0.0-beta.0 - Move to use & forward syntax. * v9.0.0-beta.0 - add templates back in. * v9.0.0-beta.0 - resolve paths. * v9.0.0-beta.0 - fix paths. * Updating README and CHANGELOG * v9.0.0-beta.0 - Move trumps back. * v9.0.0-beta.0 - Move trumps to correct position * v9.0.0-beta.0 - PR comments. * v9.0.0-beta.0 - PR comments. * v9.0.0-beta.0 - PR comments. * v9.0.0-beta.0 - PR comments. Co-authored-by: ashleynolan <[email protected]> * v9.0.0-beta.1 - Fixed mixin reference. (#370) * v9.0.0-beta.1 - Fixed mixin reference. * v9.0.0-beta.1 - update changelog. * v9.0.0-beta.2 - update @use rules in _type.scss (#371) * fix line-height function call * bump beta version * import as wildcard * remove wildcard from use statements * update changelog * fix zindex * V9.0.0 beta.4 - fix some missing modules (#373) * update functions * update mixin * update changelog and bump package version * V9-0.0 beta.5 - fix circular reference (#375) * update functions * update mixin * update changelog and bump package version * remove circular references from variables, funcs and mixins * update version and changelog * remove debug code * tidy code * [email protected] - Scss unit testing (#376) * install sass-true * install glob * add working function unit tests * test a mixin * bump package and changelog * rename some tests * Update CHANGELOG.md Co-authored-by: Ashley Watson-Nolan <[email protected]> * Update src/test/scss/scss.spec.js Co-authored-by: Ashley Watson-Nolan <[email protected]> * Update src/test/scss/scss.spec.js Co-authored-by: Ashley Watson-Nolan <[email protected]> * update test paths * remove eslint override * update test names * rename setup file * Update src/test/scss/tools/mixins/type.spec.scss Co-authored-by: Xander Marjoram <[email protected]> Co-authored-by: Ashley Watson-Nolan <[email protected]> Co-authored-by: Xander Marjoram <[email protected]> * v9.0.0-beta.7 - scss unit tests on publish (#377) * v8.3.0 - Add sass:map. (#372) * v8.3.0 - Add sass:map. * v8.3.0 - PR comment. * test scss before publishing * update test script to run concurrently * add circleci config * v8.4.0 - Circleci setup (#378) * Add .circleci/config.yml * Add .circleci/config.yml * setup circle * remove travis config Co-authored-by: Kevin Rodrigues <[email protected]> * v9.0.0-beta.8 - Remove tilde import. (#382) * v9.0.0-beta.8 - Remove tilde import. * v9.0.0-beta.8 - Remove tilde import. * v9.0.0-beta.9 - Remove listingSkeleton mixin (#383) * Remove listingSkeleton mixin and bump version * Update readme Co-authored-by: Kathy Lee <[email protected]> * v9.0.0-beta.10 – $font-size-base fix and minor design token update (#384) Co-authored-by: Ashley Watson-Nolan <[email protected]> * v9.0.0-beta.11 – font-size mixin updated to new default and package updates (#385) Co-authored-by: Ashley Watson-Nolan <[email protected]> * v9.0.0-beta.12 - Add back listing skeleton. (#386) * v9.0.0-beta.12 - Add back listing skeleton. * v9.0.0-beta.12 - Fix spelling. * v9.0.0 - PR comment. * v9.0.0 - version release v9 * v9.0.0 - remove changelog entry. * v9.0.0 - Add back previous beta log. Co-authored-by: ashleynolan <[email protected]> Co-authored-by: Jamie Maguire <[email protected]> Co-authored-by: Ashley Watson-Nolan <[email protected]> Co-authored-by: Xander Marjoram <[email protected]> Co-authored-by: Kathy Lee <[email protected]> Co-authored-by: Kathy Lee <[email protected]> Co-authored-by: Ashley Watson-Nolan <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed
@use&@forwardsyntax in preference toimportstatements due to deprecation.TODO