-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(redis): Support using Unix socket #353
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
I wonder if it would be worth it to unify the option names around sockets. Right now, process-compose-flake has httpServer.uds = "path-relative-to-project-root"
, redis has unixSocket = "path-relative-to-data-dir"
and postgres has socketDir = "path-relative-to-project-root
" (with no way to specify the name, but just the directory; I think it's okay though). One annoyance with the process-compose uds option is that using "data/process-compose.socket"
won't automatically create the data/
directory and instead fail.
Usually we try to match what’s upstream so users coming from there don’t have a hard time figuring out options. For |
Ah, yeah, that makes perfect sense!
I am not sure what the postgres config file instruction for this is called, but I guess using this would make sense. Maybe this even is Overall, I don't really mind, all options are somewhat okay to find. Since different programs have different ways of offering the same functionality, some heterogeneity in the naming here is probably unavoidable. I suppose finding a unified way that intuitively makes sense is not as easy as I initially made it out to be. Good documentation can probably make any naming scheme work |
resolves #352