Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

redis: unixSocket broken for relative socket paths #365

Closed
shivaraj-bh opened this issue Oct 13, 2024 · 0 comments · Fixed by #389
Closed

redis: unixSocket broken for relative socket paths #365

shivaraj-bh opened this issue Oct 13, 2024 · 0 comments · Fixed by #389
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@shivaraj-bh
Copy link
Member

shivaraj-bh commented Oct 13, 2024 •
edited by srid
Loading

I think this doesn't work as intended, if I specify unixSocket = "redis.socket";, which is also a relative path, the socket will be created at data/r1/redis.socket. I think the check should be ! lib.hasPrefix "/" config.unixSocket.

Originally posted by @niklasmohrin in #353 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(redis): unixSocket logic broken for relative socket paths juspay/services-flake
1 participant
@shivaraj-bh