Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nix_rs(nix_eval): Don't capture stderr #298

Merged
merged 11 commits into from
Oct 7, 2024
Merged

nix_rs(nix_eval): Don't capture stderr #298

merged 11 commits into from
Oct 7, 2024

Conversation

shivaraj-bh
Copy link
Member

@shivaraj-bh shivaraj-bh commented Oct 7, 2024

Resolves #209

PRs filed tangential to this:

@shivaraj-bh
Copy link
Member Author

image

Tried on github:nammayatri/nammayatri

Copy link
Member

@srid srid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, 'tis good to see a functional PR ready to refactor/merge.

crates/nix_rs/src/command.rs Outdated Show resolved Hide resolved
crates/nix_rs/src/copy.rs Outdated Show resolved Hide resolved
@srid srid changed the title nix_rs(nix_eval): Display progress by inheriting stderr from parent process nix_rs(nix_eval): Display progress by inheriting stderr from parent process Oct 7, 2024
@srid srid changed the title nix_rs(nix_eval): Display progress by inheriting stderr from parent process nix_rs(nix_eval): Let parent inherit stderr Oct 7, 2024
@srid srid changed the title nix_rs(nix_eval): Let parent inherit stderr nix_rs(nix_eval): Don't capture stderr Oct 7, 2024
@srid srid merged commit 1555b72 into main Oct 7, 2024
6 checks passed
@srid srid deleted the nix-eval-progress branch October 7, 2024 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

om show: Display progress
2 participants