-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add shortName
for quiet
flag
#11652
Add shortName
for quiet
flag
#11652
Conversation
How does this interact with |
I overlooked that. That explains why the CI is failing. In that case, adding the flag with Line 104 in 26c3fc1
|
Resolves #209 PRs filed tangential to this: - NixOS/nix#11652 --------- Co-authored-by: Sridhar Ratnakumar <[email protected]>
This PR adds `q` as a `shortName` for the `quiet` flag for `nix` command, overriding https://github.com/NixOS/nix/blob/26c3fc11eada3fa7df0284190095868a947fefe2/src/libmain/common-args.cc#L23-L28. Since this flag can be repeated, it simplifies usage by allowing `nix -qq ...` instead of `nix --quiet --quiet ...`.
6de01fc
to
efc597c
Compare
I feel that |
Discussed in meeting:
Decision: CLOSE, reopen if we have additional user requests for the short flag or more use-cases come to light |
https://github.com/NixOS/nix/blob/master/CONTRIBUTING.md#making-changes-to-nix See also the guidance here re misc new features. Ideally one maintainers could handle this async, but we're not very good at that, so instead these things gum up our delicate process. Sorry. |
Motivation
This PR adds
q
as ashortName
for thequiet
flag fornix
command, overriding
nix/src/libmain/common-args.cc
Lines 23 to 28 in 26c3fc1
Since this flag can be repeated, it simplifies usage by allowing
nix -qq ...
instead ofnix --quiet --quiet ...
.Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.