Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Adding millisecond to Kafka timestamp #5202

Merged
merged 3 commits into from
Jul 5, 2024

Conversation

ShivanshMathurJuspay
Copy link
Contributor

@ShivanshMathurJuspay ShivanshMathurJuspay commented Jul 4, 2024

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

Adds millisecond timestamp to the kafka timestamp, would help in solving the re-ordering of events in kafka while pushing

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

How did you test it?

Screenshot 2024-07-04 at 3 02 32 PM Screenshot 2024-07-04 at 3 02 50 PM Screenshot 2024-07-04 at 3 07 25 PM

Checklist

  • I formatted the cod
  • cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible

@ShivanshMathurJuspay ShivanshMathurJuspay requested a review from a team as a code owner July 4, 2024 09:33
@ShivanshMathurJuspay ShivanshMathurJuspay requested a review from a team July 4, 2024 09:34
@ShivanshMathurJuspay ShivanshMathurJuspay self-assigned this Jul 4, 2024
@pixincreate pixincreate added this pull request to the merge queue Jul 5, 2024
Merged via the queue into main with commit 00f9ed4 Jul 5, 2024
15 checks passed
@pixincreate pixincreate deleted the chore/kafka_event_millisecond_timestamp branch July 5, 2024 06:45
pixincreate added a commit that referenced this pull request Jul 5, 2024
…ify-cypress

* 'main' of github.com:juspay/hyperswitch: (22 commits)
  refactor: Adding millisecond to Kafka timestamp (#5202)
  chore(version): 2024.07.05.0
  fix(user_auth_method): make id option in auth select (#5213)
  Docs: Updated API - ref for payments (#5172)
  feat(core): add merchant order reference id (#5197)
  feat(analytics): Refund status serialization issue for ckh analytics (#5199)
  fix(router): `override setup_future_usage` filed to on_session based on merchant config (#5195)
  feat(cypress): make tests forcefully skippable (#5176)
  feat(core): Added integrity framework for Authorize and Sync flow with connector as Stripe (#5109)
  ci(cypress): Update card number for adyen and status for paypal (#5192)
  refactor(cypress): error handling and add sync refunds in places where missing (#5128)
  feat(analytics): FRM Analytics (#4880)
  chore(version): 2024.07.04.0
  feat(pm_auth): Added balance check for PM auth bank account (#5054)
  refactor(payment_methods): add appropriate missing logs (#5190)
  refactor(migrations): add commands to make file to run migrations for api v2 (#5169)
  chore(version): 2024.07.03.0
  fix(event): Updated the ApiEventMetric (#5126)
  feat(router): add refunds manual-update api (#5094)
  refactor(payment_link): logs payment links logs coverage (#4918)
  ...
Narayanbhat166 pushed a commit that referenced this pull request Jul 8, 2024
Co-authored-by: hyperswitch-bot[bot] <148525504+hyperswitch-bot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Event Generation] KafkaTimestamp change from second to millisecond
4 participants