Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(router): add refunds manual-update api #5094

Merged
merged 2 commits into from
Jul 2, 2024
Merged

feat(router): add refunds manual-update api #5094

merged 2 commits into from
Jul 2, 2024

Conversation

sai-harsha-vardhan
Copy link
Contributor

@sai-harsha-vardhan sai-harsha-vardhan commented Jun 24, 2024 •
edited
Loading

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

add refunds manual-update api

refunds manual-update api allows to update the refund details like status, error code and error message

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

How did you test it?

Tested Manually

  1. Create a refund
    image

  2. Check the status, error code and message in DB
    image

  3. Call Manual Update API for refund
    CURL

curl --location --request PUT '{{API_BASE_URL}}/refunds/{{refund_id}}/manual-update' \
--header 'Content-Type: application/json' \
--header 'Accept: application/json' \
--header 'api-key: {{ADMIN_API_KEY}}' \
--data-raw '{
    "merchant_id": "{{MERCHANT_ID}}",
    "status": "failed",
    "error_code": "code",
    "error_message": "message"
}'

image

  1. Observe the changes in DB
    image

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible

@sai-harsha-vardhan sai-harsha-vardhan added A-core Area: Core flows C-feature Category: Feature request or enhancement S-waiting-on-review Status: This PR has been implemented and needs to be reviewed labels Jun 24, 2024
@sai-harsha-vardhan sai-harsha-vardhan added this to the June 2024 Release milestone Jun 24, 2024
@sai-harsha-vardhan sai-harsha-vardhan self-assigned this Jun 24, 2024
@sai-harsha-vardhan sai-harsha-vardhan requested review from a team as code owners June 24, 2024 08:38
sahkal
sahkal previously approved these changes Jun 26, 2024
View reviewed changes
Copy link
Contributor

@sahkal sahkal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

ivor11
ivor11 previously approved these changes Jun 26, 2024
View reviewed changes
@likhinbopanna likhinbopanna added this pull request to the merge queue Jun 26, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to a conflict with the base branch Jun 26, 2024
@sai-harsha-vardhan sai-harsha-vardhan dismissed stale reviews from ivor11 and sahkal via 7d5057a July 2, 2024 06:38
@tsdk02 tsdk02 self-requested a review July 2, 2024 07:10
@Gnanasundari24 Gnanasundari24 added this pull request to the merge queue Jul 2, 2024
Merged via the queue into main with commit 9bc7801 Jul 2, 2024
15 checks passed
@Gnanasundari24 Gnanasundari24 deleted the add-refunds-manual-update-api branch July 2, 2024 13:26
pixincreate added a commit that referenced this pull request Jul 5, 2024
@pixincreate
Merge branch 'main' of github.com:juspay/hyperswitch into fixtures-un…
802a1d7 
…ify-cypress

* 'main' of github.com:juspay/hyperswitch: (22 commits)
  refactor: Adding millisecond to Kafka timestamp (#5202)
  chore(version): 2024.07.05.0
  fix(user_auth_method): make id option in auth select (#5213)
  Docs: Updated API - ref for payments (#5172)
  feat(core): add merchant order reference id (#5197)
  feat(analytics): Refund status serialization issue for ckh analytics (#5199)
  fix(router): `override setup_future_usage` filed to on_session based on merchant config (#5195)
  feat(cypress): make tests forcefully skippable (#5176)
  feat(core): Added integrity framework for Authorize and Sync flow with connector as Stripe (#5109)
  ci(cypress): Update card number for adyen and status for paypal (#5192)
  refactor(cypress): error handling and add sync refunds in places where missing (#5128)
  feat(analytics): FRM Analytics (#4880)
  chore(version): 2024.07.04.0
  feat(pm_auth): Added balance check for PM auth bank account (#5054)
  refactor(payment_methods): add appropriate missing logs (#5190)
  refactor(migrations): add commands to make file to run migrations for api v2 (#5169)
  chore(version): 2024.07.03.0
  fix(event): Updated the ApiEventMetric (#5126)
  feat(router): add refunds manual-update api (#5094)
  refactor(payment_link): logs payment links logs coverage (#4918)
  ...
@SanchithHegde SanchithHegde removed the S-waiting-on-review Status: This PR has been implemented and needs to be reviewed label Jul 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tsdk02 tsdk02 tsdk02 approved these changes

@sahkal sahkal sahkal approved these changes

@ivor11 ivor11 Awaiting requested review from ivor11

Assignees

@sai-harsha-vardhan sai-harsha-vardhan

Labels
A-core Area: Core flows C-feature Category: Feature request or enhancement
Projects
None yet
Milestone
July 2024 Release
Development

Successfully merging this pull request may close these issues.
7 participants
@sai-harsha-vardhan @sahkal @tsdk02 @ivor11 @SanchithHegde @bernard-eugine @Gnanasundari24