refactor: use hashmap deserializer for generic_link options #5157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
refactor: use url crate for handling URLs instead of strings in generic_link flows
2 tasks
2 tasks
Comment on lines
149
to
153
| link: url::Url::parse(url) | ||
| .change_context(errors::ApiErrorResponse::InternalServerError) | ||
| .attach_printable_lazy(|| { | ||
| format!("Failed to parse the payment method collect link - {}", url) | ||
| })?, |
There was a problem hiding this comment.
If this URL is going to be an external input (say provided by the merchant), then raising an internal server error may not be suitable. If it is something that we generate, then it can be an internal server error.
Also, is making it a Url in the other places an option here?
There was a problem hiding this comment.
By other places, do you mean making it a Url in storage models?
I have kept the URL specific fields in storage models as a String. It's going to use Url in every place (API interface + data injection in HTML) other than storage models
SanchithHegde
previously approved these changes
Jul 1, 2024
hyperswitch-bot
bot
added
the
M-api-contract-changes
SanchithHegde
previously approved these changes
Jul 1, 2024
SanchithHegde
previously approved these changes
Jul 1, 2024
sahkal
previously approved these changes
Jul 1, 2024
sahkal
approved these changes
Jul 1, 2024
SanchithHegde
approved these changes
Jul 1, 2024
pixincreate
added a commit
that referenced
this pull request
Jul 3, 2024
…ror-handling-in-cypress * 'main' of github.com:juspay/hyperswitch: fix: realtime user analytics (#5129) refactor: use hashmap deserializer for generic_link options (#5157) refactor(router): changed payment method token TTL to api contract based config from const value (#5115) feat(router): collect billing details from wallet connector based on the `collect_billing_details_from_wallet_connector` field (#5065)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refactor: use url crate for handling URLs instead of strings in generic_link flows
Type of Change
Description
This PR includes below items
requires_fulfillmenttoProcessingstate in payout link's status UIurlcrate instead of StringAdditional Changes
Motivation and Context
How did you test it?
Checklist
cargo +nightly fmt --allcargo clippy