refactor: use HashSet instead of Vec

juspay · Jul 1, 2024 · 4d14b0f · 4d14b0f
1 parent 3dd6494
commit 4d14b0f
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 11 deletions.
diff --git a/api-reference/openapi_spec.json b/api-reference/openapi_spec.json
@@ -9127,7 +9127,8 @@
             "items": {
               "$ref": "#/components/schemas/PaymentMethodType"
             },
-            "description": "An array of associated payment method types"
+            "description": "An array of associated payment method types",
+            "uniqueItems": true
           }
         }
       },

diff --git a/crates/common_utils/src/link_utils.rs b/crates/common_utils/src/link_utils.rs
@@ -1,6 +1,6 @@
 //! Common
 
-use std::primitive::i64;
+use std::{collections::HashSet, primitive::i64};
 
 use common_enums::enums;
 use diesel::{
@@ -206,6 +206,6 @@ pub struct EnabledPaymentMethod {
     pub payment_method: enums::PaymentMethod,
 
     /// An array of associated payment method types
-    #[schema(value_type = Vec<PaymentMethodType>)]
-    pub payment_method_types: Vec<enums::PaymentMethodType>,
+    #[schema(value_type = HashSet<PaymentMethodType>)]
+    pub payment_method_types: HashSet<enums::PaymentMethodType>,
 }
diff --git a/crates/router/src/core/payout_link.rs b/crates/router/src/core/payout_link.rs
@@ -15,7 +15,7 @@ use crate::{
     errors,
     routes::{app::StorageInterface, SessionState},
     services::{self, GenericLinks},
-    types::{api::enums, domain},
+    types::domain,
 };
 
 pub async fn initiate_payout_link(
@@ -134,7 +134,7 @@ pub async fn initiate_payout_link(
             {
                 let enabled_payment_method = link_utils::EnabledPaymentMethod {
                     payment_method,
-                    payment_method_types: payment_method_types.into_iter().collect(),
+                    payment_method_types,
                 };
                 default_enabled_payout_methods.push(enabled_payment_method);
             }
@@ -299,12 +299,10 @@ pub async fn filter_payout_methods(
             }
         }
     }
-    for (pm, method_types) in payment_method_list_hm {
-        if !method_types.is_empty() {
-            let payment_method_types: Vec<enums::PaymentMethodType> =
-                method_types.into_iter().collect();
+    for (payment_method, payment_method_types) in payment_method_list_hm {
+        if !payment_method_types.is_empty() {
             let enabled_payment_method = link_utils::EnabledPaymentMethod {
-                payment_method: pm,
+                payment_method,
                 payment_method_types,
             };
             response.push(enabled_payment_method);