-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(core): billing_details inclusion in Payment Intent #5090
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prajjwalkumar17
added
A-core
Area: Core flows
C-feature
Category: Feature request or enhancement
M-database-changes
Metadata: This PR involves database schema changes
labels
Jun 24, 2024
…hub.com/juspay/hyperswitch into feat/business_address_in_payment_intent
…hub.com/juspay/hyperswitch into feat/business_address_in_payment_intent
prajjwalkumar17
commented
Jun 25, 2024
prajjwalkumar17
commented
Jun 25, 2024
lsampras
reviewed
Jul 1, 2024
crates/hyperswitch_domain_models/src/payments/payment_intent.rs
Outdated
Show resolved
Hide resolved
Narayanbhat166
previously approved these changes
Jul 4, 2024
prajjwalkumar17
changed the title
feat(core): billing_address_details inclusion in Payment Intent
feat(core): billing_details inclusion in Payment Intent
Jul 5, 2024
Comment on lines
+224
to
+231
let billing_details: Option<Address> = billing_address.as_ref().map(From::from); | ||
payment_intent.billing_details = billing_details | ||
.clone() | ||
.async_and_then(|_| async { | ||
create_encrypted_data(key_store, billing_details.clone()).await | ||
}) | ||
.await; | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
here we are updating payment_intent in get trackers, and in other places we are updating payment_intent in update trackers. This can be made consistent
Narayanbhat166
approved these changes
Jul 5, 2024
swangi-kumari
approved these changes
Jul 5, 2024
lsampras
approved these changes
Jul 5, 2024
pixincreate
added a commit
that referenced
this pull request
Jul 8, 2024
…ify-cypress * 'main' of github.com:juspay/hyperswitch: chore(version): 2024.07.08.0 fix(connector): [adyen] remove browser info for mit and [paypal] add refund key in headers (#5225) chore(version): 2024.07.06.0 feat(router): Pass the shipping email whenever the billing details are included in the session token response (#5228) fix(cypress): fix metadata missing while creating connector if not in auth (#5215) refactor: fix unit and documentation tests (#4754) feat(events): add hashed customer_email and feature_metadata (#5220) feat(events): Add payment metadata to hyperswitch-payment-intent-events (#5170) fix(analytics): using HashSet to represent the returned metrics (#5179) feat(core): billing_details inclusion in Payment Intent (#5090) feat(router): pass fields to indicate if the customer address details to be connector from wallets (#5210) fix(refunds): Add aliases on refund status for backwards compatibility (#5216) Feat(connector): [BRAINTREE] Implement Card Mandates (#5204)
Narayanbhat166
pushed a commit
that referenced
this pull request
Jul 8, 2024
Co-authored-by: hyperswitch-bot[bot] <148525504+hyperswitch-bot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A-core
Area: Core flows
C-feature
Category: Feature request or enhancement
M-database-changes
Metadata: This PR involves database schema changes
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
Adds a new column in Payment Intent for storing billing address details(Encrypted)
Additional Changes
The Db Migration:
Motivation and Context
How did you test it?
The testing scenarios and flow is as follow:
1. Payment Create
2. Payment Update
3. Payment Confirm
Checklist
cargo +nightly fmt --all
cargo clippy