-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: fix unit and documentation tests #4754
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CI changes, LGTM.
f9322ef
to
204615f
Compare
68b7344
to
d50cab3
Compare
Approved on behalf of routing. |
…stable toolchain jobs
d50cab3
to
d8bfe63
Compare
I've rebased the PR on a recent |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CI stuff, LGTM!
…ify-cypress * 'main' of github.com:juspay/hyperswitch: chore(version): 2024.07.08.0 fix(connector): [adyen] remove browser info for mit and [paypal] add refund key in headers (#5225) chore(version): 2024.07.06.0 feat(router): Pass the shipping email whenever the billing details are included in the session token response (#5228) fix(cypress): fix metadata missing while creating connector if not in auth (#5215) refactor: fix unit and documentation tests (#4754) feat(events): add hashed customer_email and feature_metadata (#5220) feat(events): Add payment metadata to hyperswitch-payment-intent-events (#5170) fix(analytics): using HashSet to represent the returned metrics (#5179) feat(core): billing_details inclusion in Payment Intent (#5090) feat(router): pass fields to indicate if the customer address details to be connector from wallets (#5210) fix(refunds): Add aliases on refund status for backwards compatibility (#5216) Feat(connector): [BRAINTREE] Implement Card Mandates (#5204)
Type of Change
Description
This PR enables the usage of
sccache
for caching compilation artifacts in the CI-pr workflow, and fixes the existing unit and documentation tests. I'll be taking up running the unit and documentation on pull requests in a separate PR, with some more CI workflow improvments.Motivation and Context
Fixing unit tests so that they can be run as part of pull request checks.
How did you test it?
I've run unit tests locally with the following command (with locally running Postgres and Redis servers), and they pass:
Further, running documentation tests using the following command succeeds:
I'm unable to include a screenshot of the documentation test run, since the output is too long.
Checklist
cargo +nightly fmt --all
cargo clippy