feat(connector): [Coinbase] Add order id as the reference id #2469
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srujanchikke
reviewed
Oct 5, 2023
| @@ -155,7 +155,7 @@ impl<F, T> | |||
| message: "Please check the transaction in coinbase dashboard and resolve manually" | |||
| .to_string(), | |||
| }), | |||
| connector_response_reference_id: None, | |||
| connector_response_reference_id: Some(item.response.data.id.clone()), | |||
There was a problem hiding this comment.
Hi @Ceres445 ,
clone is not required here .
SanchithHegde
added
A-connector-integration
srujanchikke
added
S-waiting-on-approval
ArjunKarthik
approved these changes
Oct 7, 2023
|
@Ceres445 Thanks for the PR |
ArjunKarthik
added
hacktoberfest-accepted
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
Relevant documentation here. I'm not 100% sure what
codeis in the documentation but they haven't provided more clarity, the only other identifier for the transaction is id, so I've used that.Additional Changes
Motivation and Context
Fixes #2326
How did you test it?
Checklist
cargo +nightly fmt --allcargo clippy