Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE]: [Coinbase] Use connector_response_reference_id as reference to merchant #2326

Closed
2 tasks done
Sakilmostak opened this issue Sep 22, 2023 · 9 comments · Fixed by #2469
Closed
2 tasks done
Assignees
Labels
A-connector-integration Area: Connector integration C-feature Category: Feature request or enhancement good first issue Good for newcomers hacktoberfest Issues that are up for grabs for Hacktoberfest participants

Comments

@Sakilmostak
Copy link
Contributor

📝 Feature Description

  • Reference id are used to map transactions in the connector’s dashboard.
  • Hyperswitch manages several reference ids, such as payment_id, attempt_id, and connector_transaction_id for a single transaction.
  • However, merchants may encounter uncertainty when determining which ID to utilize in the connector dashboard to identify the payment.

🔨 Possible Implementation

  • When we receive a response from the connector for the payment, we deserialize it and populate the response field in RouterData.
  • For the TransactionResponse type, we must fill the connector_response_reference_id with a corresponding reference id for the merchant to identify the transaction.
  • One might need to have exposure to api docs of the connector for which it is being implemented to decide what to fill in connector_response_reference_id.
  • You can check this PR for further reference feat(connector): [Stripe, Adyen, Checkout] Add reference ID support for retries #1735

🔖 Note: All the changes needed should be contained within hyperswitch/crates/router/src/connector/

📦 Have you spent some time checking if this feature request has been raised before?

  • I checked and didn't find a similar issue

📦 Have you read the Contributing Guidelines?

✨ Are you willing to submit a PR?

@Sakilmostak Sakilmostak added A-connector-integration Area: Connector integration C-feature Category: Feature request or enhancement S-awaiting-triage Status: New issues that have not been assessed yet hacktoberfest Issues that are up for grabs for Hacktoberfest participants labels Sep 22, 2023
@Sakilmostak Sakilmostak changed the title [FEATURE]: [Coinbase] Use connector_response_reference_id as reference to merchant [FEATURE]: [Coinbase] Use connector_response_reference_id as reference to merchant Sep 22, 2023
@VedantKhairnar VedantKhairnar added the good first issue Good for newcomers label Sep 28, 2023
@Kota-Karthik
Copy link

@Sakilmostak @AkshayaFoiger
I am interested in doing this issue
so kindly assign me this
Thank You : )

@AkshayaFoiger
Copy link
Contributor

Hey @Kota-Karthik, I see that you're already assigned to #2351. For now, we'll leave this issue open to any other interested contributors. You may pick this up once your work on #2351 is completed, and if no other contributors have expressed interest on this. I hope that's fine by you

Ceres445 added a commit to Ceres445/hyperswitch that referenced this issue Oct 1, 2023
@Ceres445
Copy link
Contributor

Ceres445 commented Oct 1, 2023

I tried checking coinbase documentation and landed at this but it doesn't describe the data event properly or give any context as to what it uses as a reference id for the transaction. The structure also has different fields than the example provided in the documentation. Can anyone point me in the correct direction?

@AkshayaFoiger
Copy link
Contributor

Hello @Ceres445,

I noticed you were referring to the webhook structure, and I recommend consulting Coinbase's API documentation for more detailed information. Additionally, while searching for the connector reference ID, please be aware that some connectors may not require a payment reference ID in their payment requests. However, it is expected that they will provide a payment-specific ID in their response, which should then be populated as the 'connector_reference_id,' as specified in the issue.

I trust that this information proves valuable. If you have any further inquiries, please feel free to reach out.

@Ceres445
Copy link
Contributor

Ceres445 commented Oct 3, 2023

@AkshayaFoiger can you please assign me this issue

@AkshayaFoiger
Copy link
Contributor

AkshayaFoiger commented Oct 3, 2023

Hey @Ceres445, sure! I've assigned this to you.

@AkshayaFoiger AkshayaFoiger removed the S-awaiting-triage Status: New issues that have not been assessed yet label Oct 3, 2023
@VedantKhairnar
Copy link
Contributor

Hey @Ceres445 ,
Let us know if you face any issues. Happy to help! : )

Ceres445 added a commit to Ceres445/hyperswitch that referenced this issue Oct 4, 2023
@Ceres445
Copy link
Contributor

Ceres445 commented Oct 4, 2023

I'm having some issues running the test script cargo test --package router --test connectors -- stripe:: --test-threads=1. But I've read the documentation mentioned above and made the changes.

@srujanchikke
Copy link
Contributor

Hello @Ceres445 ,

No worries, Don't need to run the test script . Please raise a PR to main!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-connector-integration Area: Connector integration C-feature Category: Feature request or enhancement good first issue Good for newcomers hacktoberfest Issues that are up for grabs for Hacktoberfest participants
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants