fix(connector): stripe mandate failure and other ui tests failures #1742
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e payment through card stripe
hrithikesh026
added
C-bug
hrithikesh026
requested review from
ArjunKarthik,
SanchithHegde and
Narayanbhat166
jagan-jaya
previously approved these changes
Jul 19, 2023
…e payment for card in stripe
jagan-jaya
previously approved these changes
Jul 19, 2023
Narayanbhat166
requested changes
Jul 19, 2023
ArjunKarthik
previously approved these changes
Jul 19, 2023
…curring_mandate_payment
…curring_mandate_payment
…curring_mandate_payment
…date_payment' of https://github.com/juspay/hyperswitch into payment_method_type_not_required_for_card_recurring_mandate_payment
Signed-off-by: chikke srujan <[email protected]>
…date_payment' of github.com:juspay/hyperswitch into payment_method_type_not_required_for_card_recurring_mandate_payment
…date_payment' of https://github.com/juspay/orca into payment_method_type_not_required_for_card_recurring_mandate_payment
Signed-off-by: chikke srujan <[email protected]>
…date_payment' of https://github.com/juspay/orca into payment_method_type_not_required_for_card_recurring_mandate_payment
hrithikesh026
changed the title
Narayanbhat166
approved these changes
Jul 19, 2023
ArjunKarthik
approved these changes
Jul 19, 2023
jagan-jaya
approved these changes
Jul 19, 2023
SanchithHegde
approved these changes
Jul 19, 2023
SanchithHegde
deleted the
payment_method_type_not_required_for_card_recurring_mandate_payment
branch
SanchithHegde
removed
P-high
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
payment_method_types[]with all payment payment_intents. This is a list of all supported payment_method_types for that payment intent.If this is
None, Stripe takes ["Card"] as default value.But this field
payment_method_types[]is made mandatory in my recent PR #1119 . This caused recurring mandate payment to fail if payment_method_type is not passed during mandate creation.In #1119
payment_method_types[]is taken inferred frompayment_method_typevalue passed during mandate creation call.But Card recurring mandate in stripe can be done without passing
payment_method_typein mandate create call. (Because default is Card).Mandate creation done for other payment_methods would require
payment_method_typeto be passed in create request body.Additional Changes
Motivation and Context
How did you test it?
Manual
Checklist
cargo +nightly fmt --allcargo clippy