feat(mandates): recurring payment support for bank redirect and bank debit payment method for stripe #1119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hrithikesh026
added
A-core
jarnura
added
S-waiting-on-author
hrithikesh026
force-pushed
the
recurring_payment_support_bank_debit_stripe
branch
from
e7e2bf9
to
0cad76d
Compare
ArjunKarthik
previously approved these changes
Jul 17, 2023
Comment on lines
+1689
to
+1690
| // .set_metadata(data.metadata), | ||
| // we are storing PaymentMethodData in metadata of mandate |
There was a problem hiding this comment.
Then do you need the set_metadata() call here or not?
There was a problem hiding this comment.
We don't need it now. Previously metadata field in mandate table was used to to store something here. In this PR, I am storing insensitive payment_method_data in it.
SanchithHegde
previously approved these changes
Jul 17, 2023
ArjunKarthik
previously approved these changes
Jul 17, 2023
…entRedirectFlow for Stripe. To support mandate payment for bank redirect
hrithikesh026
dismissed stale reviews from ArjunKarthik and SanchithHegde
via
318f87b
ArjunKarthik
approved these changes
Jul 17, 2023
Narayanbhat166
approved these changes
Jul 17, 2023
jarnura
approved these changes
Jul 17, 2023
15 tasks
SanchithHegde
removed
P-high
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
PaymentIntentRequestfields to support the new requirementI have merged #1231 to this branch since the changes were interdependent.
So merging this branch would automatically add features of #1231
Additional Changes
Motivation and Context
How did you test it?
Checklist
cargo +nightly fmt --allcargo clippy