feat(router): implement ApiKeyInterface for MockDb
#1101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Other than that, looks good to me!
Thanks for the PR, @derekleverenz!
SanchithHegde
added
A-framework
SanchithHegde
changed the title
ApiKeyInterface for MockDb
…renz/hyperswitch into fix-996-mockdb-apikeyinterface
SanchithHegde
approved these changes
May 13, 2023
SanchithHegde
added
S-waiting-on-review
Narayanbhat166
approved these changes
May 13, 2023
jarnura
approved these changes
May 16, 2023
jarnura
added
S-ready-for-merge
and removed
S-waiting-on-review
|
@derekleverenz can we have your twitter / LinkedIn handles? Would love to give you a shoutout! |
|
Sure! Im @Coaxmetal on twitter and https://www.linkedin.com/in/derek-leverenz-b0787858/ at linkedin |
|
Thanks! Can you please enable tagging on LinkedIn, we are unable to tag your profile |
|
Ah yep, should be enabled now |
This was referenced May 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
Stores API keys in a vector in
MockDB.Additional Changes
Motivation and Context
Resolves #996.
How did you test it?
Wrote a unit test (included in the PR, but ignored). It passes locally if I make some unrelated changes to allow the test to run without needing redis, but I have it ignored for now because of that (the tests can probably be removed too, they arent vital just wanted to verify it worked)
Checklist
cargo +nightly fmt --allcargo clippy