Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Implement ReverseLookupInterface for MockDb #1115

Closed
Tracked by #172
lsampras opened this issue May 10, 2023 · 4 comments · Fixed by #2119
Closed
Tracked by #172

[FEATURE] Implement ReverseLookupInterface for MockDb #1115

lsampras opened this issue May 10, 2023 · 4 comments · Fixed by #2119
Assignees
Labels
A-framework Area: Framework C-feature Category: Feature request or enhancement good first issue Good for newcomers help wanted Extra attention is needed

Comments

@lsampras
Copy link
Member

lsampras commented May 10, 2023

Spin out from #172. Please refer to that issue for more information.

@lsampras lsampras added C-feature Category: Feature request or enhancement good first issue Good for newcomers labels May 10, 2023
@lsampras lsampras changed the title [FEATURE] Implement ApiKeyInterface for MockDb [FEATURE] Implement ReverseLookupInterface for MockDb May 10, 2023
@lsampras lsampras added A-framework Area: Framework help wanted Extra attention is needed labels May 10, 2023
@selectiveduplicate
Copy link

selectiveduplicate commented May 22, 2023

Hi.
If it's okay, I'd like to give this one a try.
I'll have a look at the codebase and get started as soon as possible. Will ping here if need any guideline. 😅
If you have any pointers for where to get it started with, please let me know.
Also, do implementing these interfaces come with any tests that I need to run to verify?

@SanchithHegde
Copy link
Member

Sure @selectiveduplicate, I've assigned this to you.

Will ping here if need any guideline.

You can also ask your queries on our Discord server if you'd prefer that.

If you have any pointers for where to get it started with, please let me know. Also, do implementing these interfaces come with any tests that I need to run to verify?

There are no existing tests for the mock implementations. However, you can refer to the mock implementations of other interfaces in recent PRs #1101 and #968 to get an idea of how it can be done. PR #1101 also includes simple tests for the implementation.

@dalprahcd
Copy link
Contributor

Hello @selectiveduplicate and @SanchithHegde, are you still working on this issue? I would like to help if possible.

@SanchithHegde
Copy link
Member

SanchithHegde commented Sep 10, 2023

@selectiveduplicate Since there's been no recent activity on this issue thread, no open PRs and no recent discussions on Discord about this issue, I'll be un-assigning you. Let me know if you're still working on this.

@dalprahcd I've assigned this to you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-framework Area: Framework C-feature Category: Feature request or enhancement good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants