-
-
Notifications
You must be signed in to change notification settings - Fork 46
Conversation
… log to .gitignore
…nto left-right-widgets
…ft-right-widgets-nocopy
Thanks @jweill-aws for starting this! |
JupyterLab 3.2.3 was released recently: https://github.com/jupyterlab/jupyterlab/releases/tag/v3.2.3 So we can update this PR to the new packages with:
|
I should be able to modify the The only additional method I need is RetroShell:
LabShell:
It seems like if we can declare |
For sure extensions should just work the same in both lab and retro. In fact most of them already do. I think the point here was to be able to make some progress on that particular TOC extension, and lay the foundations for the left and right areas so other extensions can also be used. So we can merge this PR and iterate. TOC is still a bit special for now because of the way it currently works. See jupyterlab/jupyterlab#11530 for more info. Making it compatible with RetroLab probably requires some breaking changes, and since it is part of the Here is an example of jupyterlab-github.mp4 |
Probably this is because the palette is added to the left area here: Which seems to be the case even though by default the palette is displayed as a modal now (before the default was to add it to the left area). |
@jtpio I noticed that and was confused. Is it safe to remove the palette from the left area? Does it ever display there in JupyterLab? |
Yes, the palette can be shown by config and restores useful metadata
(category). It's actually more accessible, as the links are less sensitive
to focus/mouse movements.
|
Thanks @bollwyvl — didn't realize that there was a config option to make the palette visible. This raises two questions:
|
The palette widget is still added to the left area in RetroLab, but until now it was just not displayed. I think it now shows up with the new changes in this PR:
Normally I would expect the TOC to now be picked up based on the recent upstream changes. One way to know would be to set a breakpoint in the plugin that calls |
@jtpio I noticed when I was looking into the menu item issue that the menu gets generated once, after the command palette plugin has been activated, but it doesn't get regenerated with two items after the TOC plugin has been activated. I'm concerned that the lack of a notebook tracker or a widget tracker in RetroLab's left pane may be related to this: there is no |
One way to handle this for now could be to wait for
RetroLab supports notebook trackers and other widget trackers. For example the notebook tracker plugin is added here: Line 138 in 6b47f0c
Although it's true there is no way to know a widget has been added to the left / right areas. But isn't that the case for the |
@jtpio Thanks! I've updated this PR in this way. Still not seeing the toc extension load, but at least it appears as its own item in the menu now. Progress! |
At the February 2 JupyterLab meeting, someone mentioned using a "live inspector" extension in lieu of the |
Right for reference Maybe it can be made optional so |
So many inspectors! I was actually referring to the thing called This is an implementation of a top-level jupyter message and is a great interactive computing "passive" learning tool, as it doesn't require any keystrokes, etc. to see a stream of new information This was originally a (right) sidebar, and was moved to the main area to be more flexible. In nb6, it appears in the "pager" area at the bottom of the page... i personally never liked that position, and would not be sad at all if it appeared next to the code-of-interest, and consumed some of the whitespace. It also looks to only require |
@jweill-aws FYI the RetroLab code base has now been integrated in the Notebook repo: https://github.com/jupyter/notebook/ Would you like to resume continue this PR over there? Thanks! |
Closing in favor of jupyter/notebook#6327. |
Related issue: #272
This change adds left and right widgets areas to RetroLab and enables the
toc
extension which should be available in the left area.It is WIP for a few reasons:
The primary tree view in RetroLab is not presently centered as it was before this change.(fixed)The(fixed)toc-extension
is not on the same 3.2.x branch as the other extensions are (blocked on Backport PR #11420 on branch 3.2.x (Makes ILabShell optional in toc extension) jupyterlab#11421)