Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds left and right panels #6327

Closed
wants to merge 1 commit into from

Conversation

JasonWeill
Copy link
Collaborator

Addreses #6326 by adding a left and right panel to Jupyter Notebook.

Adapted from jupyterlab/retrolab#275 which was to address jupyterlab/retrolab#272.

@github-actions
Copy link
Contributor

Binder 👈 Launch a Binder on branch jweill-aws/notebook/left-right-widgets

@jtpio jtpio marked this pull request as draft March 29, 2022 07:25
@jtpio jtpio added this to the 7.0 milestone Mar 29, 2022
@jtpio jtpio mentioned this pull request Apr 29, 2022
2 tasks
@brichet
Copy link
Contributor

brichet commented Jul 20, 2022

Is there an update on this ?
Are any features missing ?

@jtpio
Copy link
Member

jtpio commented Jul 20, 2022

I think one of the blockers was being able to reuse the table of contents extension from JupyterLab in Notebook v7.

It was not easily possible for a while but should be possible now with the latest JupyterLab 4.0.0ax pre-releases.

@jtpio
Copy link
Member

jtpio commented Jul 20, 2022

It was not easily possible for a while but should be possible now with the latest JupyterLab 4.0.0ax pre-releases.

In particular jupyterlab/jupyterlab#12374 which was released in 4.0.0a25: https://github.com/jupyterlab/jupyterlab/releases/tag/v4.0.0a25.

@jtpio
Copy link
Member

jtpio commented Jul 20, 2022

@jweill-aws were you planning to resume work on this branch?

@JasonWeill
Copy link
Collaborator Author

@jtpio I am actively working on a different project at the moment. I don't have a plan to resume work on this item in the near term.

@brichet
Copy link
Contributor

brichet commented Jul 21, 2022

Thanks for answering.
I'll take a look at it as soon as possible.

@brichet
Copy link
Contributor

brichet commented Jul 21, 2022

I rebased the PR and added the TOC dependency here.
The table of contents exists in left menu but is empty.

The widget is null after : https://github.com/jupyterlab/jupyterlab/blob/039934615eae2405f82a071152d8da8ee432727e/packages/toc-extension/src/index.ts#L274

It seems that the app.restored is resolved before the document is attached to the main area.

@jtpio
Copy link
Member

jtpio commented Jul 25, 2022

Thanks @jweill-aws and @brichet.

I don't have a plan to resume work on this item in the near term.

@brichet maybe we can open a new PR based on this commit and continue there?

@brichet
Copy link
Contributor

brichet commented Jul 25, 2022

@brichet maybe we can open a new PR based on this commit and continue there?

I opened #6487

@jtpio jtpio closed this in #6487 Oct 6, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants