Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use only SVG icons #783

Merged
merged 5 commits into from
Sep 28, 2020
Merged

Use only SVG icons #783

merged 5 commits into from
Sep 28, 2020

Conversation

fcollonval
Copy link
Member

@fcollonval fcollonval commented Sep 26, 2020 •
edited
Loading

Now that the elements lists are windowed to limit the number of rendered elements, it is safe to use svg icons everywhere.

In particular, this will benefit to get new file icon from JupyterLab core directly in the extension.

@ianhi ianhi mentioned this pull request Sep 28, 2020
Merged
@fcollonval fcollonval merged commit ed50bef into jupyterlab:master Sep 28, 2020
@fcollonval fcollonval deleted the ft/full-svg-icon branch September 28, 2020 19:45
telamonian
telamonian requested changes Sep 28, 2020
View reviewed changes
Copy link
Member

@telamonian telamonian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some cases where the font/icon color should always be white, and not tied to any theme var

src/style/FileItemStyle.ts Show resolved Hide resolved
@fcollonval fcollonval mentioned this pull request Sep 29, 2020
Closed
@ianhi ianhi mentioned this pull request Oct 6, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ianhi ianhi ianhi left review comments

@telamonian telamonian telamonian requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fcollonval @telamonian @ianhi