Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Text and icons for "selected" styles should be white #786

Closed
fcollonval opened this issue Sep 29, 2020 · 2 comments
Closed

Text and icons for "selected" styles should be white #786

fcollonval opened this issue Sep 29, 2020 · 2 comments
Labels
Good first issue Good first issue to be tackled by new contributors pkg:Frontend styling defect nonbreaking but visible problems in CSS, etc tag:Design and UX
Milestone
0.22.0

Comments

@fcollonval
Copy link
Member

The text and icons for the "selected" styles should always stay as white. This is because the "selected" background color is always --jp-brand-color1, which is a bright blue color that typically does not change from theme to theme

Originally posted by @telamonian in #783 (comment)
@fcollonval
Copy link
Member Author

@ianhi, @telamonian, for the buttons I wonder if we should not move to --md-color-xxx to increase homogeneity with core JLab:

https://github.com/jupyterlab/jupyterlab/blob/master/packages/application/style/buttons.css

@fcollonval fcollonval added this to the 0.22.0 milestone Sep 29, 2020
@fcollonval fcollonval added Good first issue Good first issue to be tackled by new contributors pkg:Frontend tag:Design and UX styling defect nonbreaking but visible problems in CSS, etc labels Sep 29, 2020
@fcollonval
Copy link
Member Author

Fix by #787

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Good first issue Good first issue to be tackled by new contributors pkg:Frontend styling defect nonbreaking but visible problems in CSS, etc tag:Design and UX
Projects
None yet
Milestone
0.22.0
Development

No branches or pull requests
1 participant
@fcollonval