Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix pointer on CommitBox not displaying #1036

Merged
merged 2 commits into from
Sep 16, 2021
Merged

Fix pointer on CommitBox not displaying #1036

merged 2 commits into from
Sep 16, 2021

Conversation

andrewhli
Copy link

@andrewhli andrewhli commented Sep 15, 2021 •
edited
Loading

PR based on @fcollonval's suggestion from this thread: #1035 (comment)

Fix pointer on CommitBox not displaying
a8e7255 
PR request based on @fcollonval's suggestion from this thread: #1035 (comment)
@welcome
Copy link

welcome bot commented Sep 15, 2021

Thanks for submitting your first pull request! You are awesome! 🤗

If you haven't done so already, check out Jupyter's Code of Conduct. Also, please make sure you followed the pull request template, as this will help us review your contribution more quickly.
welcome
You can meet the other Jovyans by joining our Discourse forum. There is also a intro thread there where you can stop by and say Hi! 👋

Welcome to the Jupyter community! 🎉

@github-actions
Copy link

Binder 👈 Launch a binder notebook on branch andrewhli/jupyterlab-git/fix_commitbox_pointer

@andrewhli
Copy link
Author

@fcollonval - Thanks for the tip. Could you please check the syntax?
Overload 1 of 2, '(...objects: NestedCSSProperties[]): string', gave the following error. Type '"auto !important"' is not assignable to type '"-moz-initial" | "inherit" | "initial" | "revert" | "unset" | "auto" | "none" | "visible" | "all" | "fill" | "stroke" | "painted" | "visibleFill" | "visiblePainted" | "visibleStroke" | PointerEvents[]'.

fcollonval
fcollonval reviewed Sep 15, 2021
View reviewed changes
Copy link
Member

@fcollonval fcollonval left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @andrewhli thanks a lot for opening this one. See my suggestion to fix the issue.

src/style/CommitBox.ts Outdated Show resolved Hide resolved
@fcollonval
Update src/style/CommitBox.ts
8bfebde 
Co-authored-by: Frédéric Collonval <[email protected]>
fcollonval
fcollonval approved these changes Sep 16, 2021
View reviewed changes
Copy link
Member

@fcollonval fcollonval left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @andrewhli

@fcollonval fcollonval merged commit 18b4479 into jupyterlab:master Sep 16, 2021
@welcome
Copy link

welcome bot commented Sep 16, 2021

Congrats on your first merged pull request in this project! 🎉
congrats
Thank you for contributing, we are very proud of you! ❤️

@fcollonval
Copy link
Member

@meeseeksdev please backport to 0.32.x

@meeseeksmachine meeseeksmachine mentioned this pull request Sep 16, 2021
Merged
meeseeksmachine pushed a commit to meeseeksmachine/jupyterlab-git that referenced this pull request Sep 16, 2021
@meeseeksmachine
Backport PR jupyterlab#1036: Fix pointer on CommitBox not displaying
27cb56d
@fcollonval fcollonval mentioned this pull request Sep 16, 2021
Closed
fcollonval pushed a commit that referenced this pull request Sep 16, 2021
@meeseeksmachine
Backport PR #1036: Fix pointer on CommitBox not displaying (#1037)
ed6b807 
Co-authored-by: Andrew H. Li <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fcollonval fcollonval fcollonval approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andrewhli @fcollonval