Tooltip not show on commit button when it is disabled

[andrewhli]

Hi,

Here are my steps so far:

1. Created private GitHub SSH key in ~/.ssh (e.g. ~/.ssh/id_x)
2. Cloned remote GitHub repo via Jupyterlab Git UI (sidebar), using the SSH URL (e.g. [email protected]:user/repo.git)
3. Edited the readme in the repo via Jupyterlab
4. Tried to commit, but the option is greyed out. There are console warnings but no errors.
5. Updated - according to krassowski: files need to be added to "Staged" to enable commits. "Maybe there should be a tooltip showing up when hovering over the greyed out "Commit" button saying "Add at least one file to the staging area to commit"?"

Would appreciate any help on this. Thanks!

[welcome]

Thank you for opening your first issue in this project! Engagement like this is essential for open source projects! 🤗

If you haven't done so already, check out Jupyter's Code of Conduct. Also, please try to follow the issue template as it helps other other community members to contribute more effectively.

You can meet the other Jovyans by joining our Discourse forum. There is also an intro thread there where you can stop by and say Hi! 👋

Welcome to the Jupyter community! 🎉

[krassowski]

Welcome! You need to add a file to the staging area so that the extension knows which file is supposed to be committed. You can do this by hovering over the entries on the "Changed" or "Untracked" list (depending on what you would like to add) which should make a plus (+) icon appear - click on it to add a file and you will be able to commit. Alternatively, use context menu in the file browser (Git submenu).

[andrewhli]

Thanks! Adding the files to "Staged" worked perfectly. Any interest to adding this step to the jupyterlab-git Readme? I've been so used to using GitHub desktop, where it only shows the changes and skips over the "Staged" step (not visible to users like me), so I didn't know this was a required step in jupyterlab-git

[krassowski]

You may like the simpleStaging option (see https://github.com/jupyterlab/jupyterlab-git#ui-settings). This step is not surprising to most Git users, but I see how the GUI is not helping currently.

Maybe there should be a tooltip showing up when hovering over the greyed out "Commit" button saying "Add at least one file to the staging area to commit"?

[andrewhli]

The tooltip makes sense. I'll change this into a feature request and rename the title

[fcollonval]

Just a note when tackling this:

• An appropriated title is already set to the button
• It is not displayed due to the style pointer-events: none; set by material-ui:

@andrewhli would like to make a PR to correct this one?

You need to add:

pointer-events: auto !important;

in the css rules:

jupyterlab-git/src/style/CommitBox.ts

Line 109 in 4623fae

export const disabledStyle = style({

[fcollonval]

Fixed by #1036