-
Notifications
You must be signed in to change notification settings - Fork 326
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add 'Discard All and Pull' button #1020
Add 'Discard All and Pull' button #1020
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for starting this @navn-r
I left some comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @navn-r I push a commit to fix missing menu items description for JLab >=3.1.
Other than that we should support that new feature as a fallback if the classical pull operation fails.
f772952
to
1b08af6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for pushing this (don't worry about the delay any help at any rate is welcomed).
I left some suggestions and it should be good to go.
Small note: for future contributions, I advice you to use a personal fork rather than the MLH one.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @navn-r I tested the latest version, we need to handle better the cases where the user cancel the discard dialog (see the review comments).
Co-authored-by: Frédéric Collonval <[email protected]>
* Remove unused command ids
Co-authored-by: Frédéric Collonval <[email protected]>
1b6f5bd
to
e98368e
Compare
aec26a4
to
6389e6e
Compare
This changes introduces a
Pull from remote (Discard all)
option to the Git MenuCloses #860
This may lead into the enhancement of #998, specifically