Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'Discard All and Pull' button #860

Closed
adammclaurin opened this issue Jan 24, 2021 · 3 comments · Fixed by #1020
Closed

Add 'Discard All and Pull' button #860

adammclaurin opened this issue Jan 24, 2021 · 3 comments · Fixed by #1020

Comments

@adammclaurin
Copy link

adammclaurin commented Jan 24, 2021

We're trying to enable an operating model where some members of the team are 'creators' of notebooks, and others are 'runners' of those notebooks. The latter group is fairly non-technical, e.g. not familiar with Python code or Git. The model to share notebooks is through Git for a few reasons (esp. compliance), but we're running into frictions because the 'runner' group easily gets confused and frustrated by the details of Git. This is often caused by the simple fact that running a notebook changes the notebook file (since the output gets saved in the file), which requires an explicit discard per file before pulling updates from the Git repo.

Perhaps an easier operating model here would be a simple 'Discard All and Pull' button to allow the 'runner' to have a one-click way to sync their local sandbox with whatever is on the repo (e.g. when the 'creator' pushes an update), without having to worry about what files changed, merging, etc.

What do you think?

Fwiw this is similar to the reason why I created #856 , and why I think #837 and #659 are such good ideas.

@adammclaurin
Copy link
Author

Alternatively, perhaps we could introduce a 'Discard' button near the 'Pull' button, that discards changes to all files at the same time, rather than requiring the user to discard one by one. We could reuse the icon from the existing Discard button.

In that case, the user could quickly click two adjacent buttons to achieve the 'Discard All and Pull' capability that I'm trying to achieve.

@fcollonval
Copy link
Member

Hey @adammclaurin thanks for the suggestion

FYI, there is already a button to discard all changes on hover of the header section (the undo arrow):
image

And alternative would be to prompt the user to choose between discarding the changes and continuing the pull or stopping pulling.

@adammclaurin
Copy link
Author

Thanks @fcollonval, I never noticed that button was there. It might be more obvious if it was up next to Pull/Push/Refresh.

Your idea re: the prompt would work as well. I'm not much of a UX person so I'll let people smarter than me figure out the most elegant way. All I'm trying to do is provide a fairly non-technical person the ability to express "just make my local copy look exactly like what's on the server" in as obvious and easy way as possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants