Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add check for user value in CollaboratorsPanel #383

Merged

Conversation

martinRenou
Copy link
Member

@martinRenou martinRenou commented Oct 24, 2024

Follow up #367.

The server awareness has no user by default, to avoid seeing it as a collaborator if not required.

Copy link
Contributor

Binder 👈 Launch a Binder on branch martinRenou/jupyter-collaboration/update_collaborator_typing

@martinRenou martinRenou added the bug Something isn't working label Oct 24, 2024
Copy link
Collaborator

@davidbrochart davidbrochart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

Copy link
Contributor

@brichet brichet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @martinRenou

@brichet
Copy link
Contributor

brichet commented Oct 24, 2024

@martinRenou I added a description.

@davidbrochart davidbrochart merged commit 2475dd3 into jupyterlab:main Oct 24, 2024
21 of 23 checks passed
@martinRenou martinRenou deleted the update_collaborator_typing branch October 24, 2024 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants