Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow opening JupyterCAD documents with the JSON viewer + Allow opening STL and STEP in JupyterLite #531

Merged
merged 4 commits into from
Oct 24, 2024
Merged

Allow opening JupyterCAD documents with the JSON viewer + Allow opening STL and STEP in JupyterLite #531

merged 4 commits into from
Oct 24, 2024

Conversation

martinRenou
Copy link
Member

@martinRenou martinRenou commented Oct 23, 2024 •
edited
Loading

Fix #454

Screenshot from 2024-10-23 14-58-14

@martinRenou martinRenou added the enhancement New Feature or improvement label Oct 23, 2024
@martinRenou martinRenou changed the title JSON viewer Allow opening JupyterCAD documents with the JSON viewer Oct 23, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 23, 2024 •
edited
Loading

Integration tests repot: appsharing.space

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 23, 2024 •
edited
Loading

Preview PR at appsharing.space

@arjxn-py
Copy link
Member

Bot please update snapshots 🫤

@martinRenou
Copy link
Member Author

There seems to be a real issue with other file types like stl and step that can't be open anymore

@martinRenou
Copy link
Member Author

Latest commit makes it work with the jupytercad app

Screenshot from 2024-10-23 16-40-52

@martinRenou martinRenou marked this pull request as draft October 23, 2024 14:42
@SylvainCorlay
Copy link
Member

Nice. Is it fixed with STEP and STL?

@martinRenou
Copy link
Member Author

nope

@martinRenou martinRenou changed the title Allow opening JupyterCAD documents with the JSON viewer Allow opening JupyterCAD documents with the JSON viewer + some bug fixes on file types Oct 23, 2024
@martinRenou martinRenou changed the title Allow opening JupyterCAD documents with the JSON viewer + some bug fixes on file types Allow opening JupyterCAD documents with the JSON viewer + bug fix on opening other file types (stl, step) in JupyterLite Oct 23, 2024
@martinRenou martinRenou changed the title Allow opening JupyterCAD documents with the JSON viewer + bug fix on opening other file types (stl, step) in JupyterLite Allow opening JupyterCAD documents with the JSON viewer + Allow opening STL and STEP in JupyterLite Oct 23, 2024
@martinRenou
Copy link
Member Author

Finally 🚀 Opening STL files in JupyterLite works now. Will apply the same changes on STEP and fix the CI later.

Screenshot from 2024-10-23 19-12-35

@martinRenou
Copy link
Member Author

The CI failures are jupyter-collaboration related. Let's get this PR on hold while collaboration gets properly fixed.

e.g. jupyterlab/jupyter-collaboration#383

@martinRenou martinRenou force-pushed the json_viewer branch 2 times, most recently from 6f3ee22 to 61c02f9 Compare October 24, 2024 12:22
@martinRenou martinRenou marked this pull request as ready for review October 24, 2024 12:22
@SylvainCorlay
Copy link
Member

Hallelujah!

@trungleduc trungleduc merged commit 049a6ae into jupytercad:main Oct 24, 2024
10 checks passed
@martinRenou martinRenou deleted the json_viewer branch October 24, 2024 15:33
@SylvainCorlay
Copy link
Member

This is looking great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SylvainCorlay SylvainCorlay SylvainCorlay approved these changes

@trungleduc trungleduc trungleduc approved these changes

Assignees
No one assigned
Labels
enhancement New Feature or improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Open .jcad files with the JSON viewer
4 participants
@martinRenou @arjxn-py @SylvainCorlay @trungleduc