adding maxWait command line flag

[dharmaquark]

Description of change

This PR introduces a new optional command line flag max-wait to support customizable timeouts (implementing suggestion made in #80 to handle use case of an instance of JupyterLab taking longer than the current 5000 ms default before the window.jupyterlab object is available)

[welcome]

Thanks for submitting your first pull request! You are awesome! 🤗

If you haven't done so already, check out Jupyter's Code of Conduct. Also, please make sure you followed the pull request template, as this will help us review your contribution more quickly.

You can meet the other Jovyans by joining our Discourse forum. There is also a intro thread there where you can stop by and say Hi! 👋

Welcome to the Jupyter community! 🎉

[jtpio]

Thanks @dharmaquark!

Galata has been moved into the core JupyterLab repository: jupyterlab/jupyterlab#10796. And we are in the process of archiving the galata repo in: #81

However it looks like we could get this change in here, and cut a new @jupyterlab/galata release (maybe the last one from this repo). Then we can focus efforts on the main jupyterlab repo.

What do you think @fcollonval @mbektas?

[dharmaquark]

Thanks @dharmaquark!

Galata has been moved into the core JupyterLab repository: jupyterlab/jupyterlab#10796. And we are in the process of archiving the galata repo in: #81

However it looks like we could get this change in here, and cut a new @jupyterlab/galata release (maybe the last one from this repo). Then we can focus efforts on the main jupyterlab repo.

What do you think @fcollonval @mbektas?

that would be great! Also happy to port this PR over to the JupyterLab repo if that ends up being easier for everyone!

[fcollonval]

FYI in the code ported to core, this is happening there. And there is no timeout on the action (except the global test timeout).

[mbektas]

However it looks like we could get this change in here, and cut a new @jupyterlab/galata release (maybe the last one from this repo). Then we can focus efforts on the main jupyterlab repo.

What do you think @fcollonval @mbektas?

Thanks @dharmaquark! @jtpio yes, sounds good to me. Lets merge this and publish a new version.

[mbektas]

LGTM!

[jtpio]

Thanks!

[welcome]

Congrats on your first merged pull request in this project! 🎉

Thank you for contributing, we are very proud of you! ❤️

[jtpio]

FYI @dharmaquark, 3.0.11-4 has been published with this change: https://github.com/jupyterlab/galata/releases/tag/v3.0.11-4

Thanks @mbektas for the release!