Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure compatibility with both sync and async contents managers #62

Merged
merged 1 commit into from
Oct 9, 2024
Merged

Ensure compatibility with both sync and async contents managers #62

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion jupyterlab_quickopen/handler.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
from fnmatch import fnmatch

from jupyter_server.base.handlers import APIHandler
from jupyter_server.utils import ensure_async
from tornado import web
from tornado.escape import json_encode

Expand Down Expand Up @@ -39,7 +40,7 @@ async def should_hide(self, entry, excludes):
any(fnmatch(entry.name, glob) for glob in excludes)
or not self.contents_manager.should_list(entry.name)
or (
await self.contents_manager.is_hidden(entry.path)
await ensure_async(self.contents_manager.is_hidden(entry.path))
and not self.contents_manager.allow_hidden
)
)
Expand Down
Loading